My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3151: Getting "Authentication failed" error in 2.10 when using HTTP_LDAP authentication method
4 people starred this issue and may be notified of changes. Back to list
Status:  ChangeUnderReview
Owner:  ----


Sign in to add a comment
 
Reported by romain.c...@gmail.com, Jan 29, 2015
*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: 2.10

What steps will reproduce the problem?
1. Use authentication method HTTP_LDAP and have gitBasicAuth set to true
2. Try to do a fetch from the gerrit repository (or any other git command that requires authentication)

What is the expected output? What do you see instead?
I expect the command to work and the authentication to succeed. Instead, I get the following message in the error_log:
"Authentication failed for XXX: password does not match the one stored in Gerrit"

It used to work fine in version 2.9.3 (the one I had before updating).

Please provide any additional information below.

I was able to work around this by changing the 'isLdapAuth' method in AuthConfig.java by adding "|| authType == AuthType.HTTP_LDAP" to the condition. I don't know if this is a proper fix but it restored the behavior that I expected.
Aug 27, 2015
Project Member #1 dougk....@gmail.com
I can confirm this bug.  I independently came to the same conclusion as you, but this actually has a lot of nuances that will break logins.  A more complete patch (sorry, based on stable-2.11 since stable-2.10 is ramping down) can be found here:
https://gerrit-review.googlesource.com/70321
Aug 27, 2015
Project Member #2 bklarson@gmail.com
Updating status at Doug K's request
Status: ChangeUnderReview
Sign in to add a comment

Powered by Google Project Hosting