| Issue 3130: | Please don't +2 when I type "LGTM" | |
| 2 people starred this issue and may be notified of changes. | Back to list |
What steps will reproduce the problem? 1. Review a change 2. Click Reply 3. Click "+1" 4. Type "LGTM after you fix X and Y" 5. Send the reply 6. Note with horror that you accidentally sent +2 Reasons why I think this is not a good idea. 1. The text when you select +1 is "Looks good to me, but someone else must approve". In other words, it's false to assume that LGTM means +2 when it could also mean +1 2. You shouldn't be overriding input I already made (clicking on +1) 3. If you ever add an "auto submit on +2" feature, this would trigger submit when unintended.
Jan 27, 2015
Project Member
#1
david.pu...@sonymobile.com
Status:
ChangeUnderReview
Jan 28, 2015
> In other words, it's false to assume that LGTM means +2 when it could also mean +1 Just ask gerrit admin to revoke your +2 ACL, and this feature works as expected ,-)
Feb 3, 2015
(No comment was entered for this change.)
Status:
Submitted
Labels: FixedIn-2.11
Apr 16, 2015
(No comment was entered for this change.)
Status:
Released
|
|
| ► Sign in to add a comment |