| Issue 3118: | submit whole topic: wrongly submits unreviewed patches | |
| 2 people starred this issue and may be notified of changes. | Back to list |
Affected Version: master (2.10-rc1-1397-gbe09512) What steps will reproduce the problem? 1. Create two patches with same topic, submitStrategy 'cherry-pick', changes.submitWholeTopic = True 2. review only the first 3. hit submit on the this change What is the expected output? What do you see instead? change should go to pending, instead both patchsets change to state merged, but are not available via git (so not really submitted). On the second patch the reply button is now missing. Additionally I get an exception on the related changes endpoint for the second change: [2015-01-22 14:26:08,585] ERROR com.google.gerrit.httpd.restapi.RestApiServlet : Error in GET /changes/103/revisions/c3b3fa09e5a3df1752c8da687a1c732ea59d9fb8/related java.lang.NullPointerException at com.google.gerrit.server.change.GetRelated.walk(GetRelated.java:128) at com.google.gerrit.server.change.GetRelated.apply(GetRelated.java:89) at com.google.gerrit.server.change.GetRelated.apply(GetRelated.java:63) at com.google.gerrit.httpd.restapi.RestApiServlet.service(RestApiServlet.java:319) at javax.servlet.http.HttpServlet.service(HttpServlet.java:725) at com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:279) at com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:269) at com.google.inject.servlet.ServletDefinition.service(ServletDefinition.java:180) at com.google.inject.servlet.ManagedServletPipeline.service(ManagedServletPipeline.java:91) at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:85) at com.google.gerrit.httpd.GetUserFilter.doFilter(GetUserFilter.java:82) at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82) at com.google.gwtexpui.server.CacheControlFilter.doFilter(CacheControlFilter.java:73) at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82) at com.google.gerrit.httpd.RunAsFilter.doFilter(RunAsFilter.java:117) at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82) at com.google.gerrit.httpd.AllRequestFilter$FilterProxy$1.doFilter(AllRequestFilter.java:64) at com.google.gerrit.httpd.AllRequestFilter$FilterProxy.doFilter(AllRequestFilter.java:57) at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82) at com.google.gerrit.httpd.RequestContextFilter.doFilter(RequestContextFilter.java:75) at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82) at com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:119) at com.google.inject.servlet.GuiceFilter$1.call(GuiceFilter.java:133) at com.google.inject.servlet.GuiceFilter$1.call(GuiceFilter.java:130) at com.google.inject.servlet.GuiceFilter$Context.call(GuiceFilter.java:203) at com.google.inject.servlet.GuiceFilter.doFilter(GuiceFilter.java:130) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652) at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585) at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:221) at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1125) at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515) at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185) at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1059) at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97) at org.eclipse.jetty.server.handler.RequestLogHandler.handle(RequestLogHandler.java:95) at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97) at org.eclipse.jetty.server.Server.handle(Server.java:497) at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:313) at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:248) at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:540) at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:626) at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:546) at java.lang.Thread.run(Thread.java:745)
Jan 22, 2015
Project Member
#1
david.pu...@sonymobile.com
Summary:
submit whole topic: wrongly submits unreviewed patches
(was: submit whole topic: wrongly submits unrevied patches)
Jan 25, 2015
(No comment was entered for this change.)
Status:
Accepted
Cc: sbel...@google.com
Jan 28, 2015
Is the exception on the related changes endpoint occurring when the submit is done? Or is that a result of a separate call? In the latter case, it would be better to raise a separate report. I did not see that exception when I was testing the submit.
Jan 29, 2015
The error happens after the submit is done.
Jan 29, 2015
A fix is on the way at https://gerrit-review.googlesource.com/#/c/63700
Jan 29, 2015
(No comment was entered for this change.)
Status:
ChangeUnderReview
Feb 2, 2015
Mind, that once the linked change is accepted, we are too restrictive because of a cache invalidation problem. As the capability to submit is cached and the cache is only refreshed if anything related to that change id changes. The dependency of another change affecting the ability to submit a change is not yet added properly there. So you may end up seeing the submission blocked although it would be technically possible.
Feb 17, 2015
(No comment was entered for this change.)
Status:
Submitted
Labels: FixedIn-2.11
Apr 16, 2015
(No comment was entered for this change.)
Status:
Released
|
|
| ► Sign in to add a comment |