My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3111: The mouse click produces unexpected underscore character in new change view
1 person starred this issue and may be notified of changes. Back to list
Status:  Duplicate
Merged:  issue 3378
Owner:  ----
Closed:  Jan 2015


Sign in to add a comment
 
Reported by junchunx...@gmail.com, Jan 20, 2015
*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: 2.9.3

What steps will reproduce the problem?
1. Login in gerrit, modify change view to new screen. 
Click Settings > Preferences > Change View: New Screen
2. Open a file in any gerrit changes
3. Click on any line of the file. You will see an underscore character at the end of line.

What is the expected output? What do you see instead?
The underscore character at the end of line is misleading. It misleads me there is a '_' in the text.


Please provide any additional information below.
There's no problem if I change the change view to old screen.
Jan 21, 2015
Project Member #1 edwin.ke...@gmail.com
The underscore marks the position of the cursor in the file. You can use key navigation in the file [1] and add inline comments by pressing 'c' [2]. This is why it's important to see the cursor position.

[1] https://gerrit-review.googlesource.com/Documentation/user-review-ui.html#key-navigation
[2] https://gerrit-review.googlesource.com/Documentation/user-review-ui.html#add-inline-comment
Jan 21, 2015
Project Member #2 david.pu...@sonymobile.com
Works as designed.

Status: WontFix
May 19, 2015
Project Member #3 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Duplicate
Mergedinto: 3378
Sign in to add a comment

Powered by Google Project Hosting