My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3104: Inline Edit: On leaving edit mode, the ",edit" part remains in the URL
1 person starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  ----
Closed:  Jan 2015
Cc:  David.Os...@gmail.com


Sign in to add a comment
 
Project Member Reported by david.pu...@sonymobile.com, Jan 15, 2015
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: master

What steps will reproduce the problem?
1. Enter edit mode
2. Click "Done Editing"
3. See the URL

What is the expected output? What do you see instead?


Please provide any additional information below.

Jan 15, 2015
Project Member #1 David.Os...@gmail.com
This works like this in other cases as well:

1. change Diff against to be not base, say 5 latest ps is 7
2. jump to SBS2 for a file from file table
3. URL contains 5..7 suffix
4. jump back to CS2
5. change Diff against to base again
6. URL still contains 5..7 suffix

Suffix is needed to restore the state in CS2. In both cases. Dispatcher parses this suffix and pass in the state into CS2 ctor. We don't manipulate URL from with CS2 when the state is changed.
Jan 15, 2015
Project Member #2 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: WontFix
Sign in to add a comment

Powered by Google Project Hosting