| Issue 310: | ssh command line feature to submit change set | |
| 10 people starred this issue and may be notified of changes. | Back to list |
Following-up on this post, I'm not sure if a feature request was ever opened. http://groups.google.com/group/repo-discuss/browse_thread/thread/23db596448e3556c In summary, the addition of a "submit" command to the following would be a very nice feature: $ ssh -p 29418 review.source.android.com gerrit usage: gerrit COMMAND [ARGS] Available commands of gerrit are: approve create-project flush-caches ls-projects receive-pack replicate show-caches show-connections show-queue Thanks for the consideration.
Oct 29, 2009
#1
sop+code@google.com
Status:
Accepted
Jan 29, 2010
I'm fairly certain we talked about this on repo-discuss. I vaguely recall suggesting that we should treat an attempt to push a commit into the target branch as a submit command, but only if the change has been approved. This matches with our existing behavior of where we close a change when the user pushes its commit directly into the branch using the Push Branch >= +1 permission.
Jan 29, 2010
Hi Shawn- That's correct. The url to the thread on repo-discuss is listed above thanks
Jan 29, 2010
The problem (imo) with that approach, is that it leaves automated scripts without a way of submitting nicely. Of course you could make the script keep a working checkout around and fetch and repush or so, but it would be nicer to be able to just do `ssh server -p 29418 gerrit submit projectName Ic0ffee...`
Jan 29, 2010
Ah, good point. But I still think we should support submit by push. :-)
Jan 29, 2010
Yes, I agree.
Feb 1, 2010
Any plans to implement this soon?
Feb 1, 2010
Tho I prefer the git push ...:refs/heads/.. to require approved (for people that don't have Push Branch) it does seem that also having a "gerrit" subcommand would be useful. I guess both could be done.
Feb 1, 2010
Issue 428 has been merged into this issue.
May 14, 2010
(No comment was entered for this change.)
Status:
Started
Owner: nas...@codeaurora.org
Jun 11, 2010
(No comment was entered for this change.)
Owner:
mf...@codeaurora.org
Jun 15, 2010
Fixed by I5b88c8818b227de7dfc9c8a879eb5e7c7821e3b5
Status:
Fixed
Labels: FixedIn-2.1.3
Mar 27, 2012
(No comment was entered for this change.)
Status:
Released
|
|
| ► Sign in to add a comment |