My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 31: Gerrit2 upload failure
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012

Blocking:
issue 29


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Brad Larson <bklarson@gmail.com> on Wed Jan 21 10:04:46 PST 2009
Source: JIRA GERRIT-31
Affected Version: 2.0
Environment: Ubuntu, postgres 8.3.5, gwt 1.5.3

I ran a gerrit2 test upload yesterday and everything worked fine.  Today I'm
getting an error:

mydroid$ repo upload
Upload project external/zlib/:
  branch gerrit2test ( 1 commit, Wed Jan 21 11:53:14 2009 -0600):
         a2f5d7f6 This is a gerrit2 test
(y/n)? y
fatal: '/platform/external/zlib': not a Gerrit project
channel_by_id: 1: bad id: channel free
channel_input_success_failure: 1: unknown
fatal: The remote end hung up unexpectedly

--------------------------------------------
[FAILED] external/zlib/  gerrit2test      (Upload failed)

I've grepped around and can't figure out where the channel_by_id and
channel_input_success_failure lines are coming from.  Any ideas?
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Wed Jan 21 10:09:55 PST 2009

My guess is the channel_id errors are actually from your OpenSSH client, and
may be due to some bad protocol behavior on the Java based SSHD as we tear
down the channels due to the "fatal: ... not a Gerrit project" error message
above.

It should be easy to always replicate that "not a gerrit project" error:

  git push ssh://you@localhost:29418/this/is/not/a/project.git HEAD:refs/for/
none


Of course I think /platform/external/zlib is supposed to be a valid project
for Android, so I wonder if there's also some other bug going on in the upload
code path, or is your database simply missing that project definition in the
projects table?
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by Brad Larson <bklarson@gmail.com> on Wed Jan 21 11:51:33 PST 2009

I've restarted the gerrit2 server, and now the 'fatal: zlib: not a Gerrit
project' line doesn't show up, but the rest of the output is the same.  zlib
is a valid project... my first test was a change to zlib as well.

reviewdb=> select * from projects where name like '%zlib';
 project_id | description | owner_group_id | use_contributor_agreements
|          name
------------+-------------+----------------+----------------------------
+------------------------
         72 |             |              1 | N                          |
platform/external/zlib

Does gerrit2 log errors anywhere?

Thanks!
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Wed Jan 21 12:42:47 PST 2009

No, not really.  There's a lot of "catch (...)" blocks in Receive.java where
the exception should be directed to a log, but they aren't.

mina_sshd (already a huge dependency for us) uses org.slf4j.Logger /
org.slf4j.LoggerFactory to handle logging, so that's already in our
classpath.  Its log4j-ish.  Maybe a good first change for you would be to go
through and insert log statements on the catch blocks; at least then we'd get
the output on the container's STDOUT, which in hosted mode shows up in the
Eclipse Console tab, and in Jetty goes to the Jetty stdout log file.
Sep 24, 2009
#4 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Fri Jan 23 11:04:50 PST 2009

Logging is significantly improved by the following commits:

c5beb05b94aa652174fa28b5844700e56cc9cece
57492c884f32d452c128c2ec31130d325ceaa3ff
536c0503238be04c8b7962780bc0e47434dab5b7
Sep 24, 2009
#5 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Fri Jan 23 11:04:50 PST 2009

Fixed in version 2.0.
Status: Fixed
Sep 25, 2009
#6 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0
Oct 25, 2012
#7 sop@google.com
(No comment was entered for this change.)
Status: Released
Blocking: -gerrit:29 gerrit:29
Sign in to add a comment

Powered by Google Project Hosting