My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3079: Inline Edit: Javscript exception occurs when change edit is deleted
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Dec 2014
Cc:  david.pu...@sonymobile.com


Sign in to add a comment
 
Project Member Reported by David.Os...@gmail.com, Dec 23, 2014

* Create change edit by clicking on "Edit Message" button
* Delete edit by clicking on "Delete Edit" button

Observe JS exception:

Tue Dec 23 16:42:06 GMT+100 2014 Class$S657
SEVERE: (TypeError) : Cannot read property 'fromString' of nullClass$S128:
(TypeError) : Cannot read property 'fromString' of null
	at Unknown.parseFromString(gerrit_ui-0.js)
	at Unknown.fromString(gerrit_ui-0.js)
	at Unknown.parse_3(gerrit_ui-0.js)
	at Unknown.scrollToPath(gerrit_ui-0.js)
	at Unknown.onShowView_5(gerrit_ui-0.js)
	at Unknown.onShowView_0(gerrit_ui-0.js)
	at Unknown.onShowView_1(gerrit_ui-0.js)
	at Unknown.swap(gerrit_ui-0.js)
	at Unknown.display_3(gerrit_ui-0.js)
	at Unknown.onSuccess_28(gerrit_ui-0.js)
	at Unknown.applySuccess(gerrit_ui-0.js)
	at Unknown.applyAllSuccess(gerrit_ui-0.js)
	at Unknown.onSuccess_375(gerrit_ui-0.js)
	at Unknown.execute_24(gerrit_ui-0.js)
	at Unknown.onResponseReceived_0(gerrit_ui-0.js)
	at Unknown.fireOnResponseReceived(gerrit_ui-0.js)
	at Unknown.onReadyStateChange(gerrit_ui-0.js)
	at Unknown.<anonymous>(gerrit_ui-0.js)
	at Unknown.apply_7(gerrit_ui-0.js)
	at Unknown.entry0(gerrit_ui-0.js)
	at Unknown.<anonymous>(gerrit_ui-0.js)

The problem occurs, because in

* ChangeScreen2.scrollToPath()
* Change.Id.parse("1510,edit")

is called and is failing, because "1510,edit" isn't valid change id.


Dec 23, 2014
Project Member #1 David.Os...@gmail.com
https://gerrit-review.googlesource.com/62753
Status: ChangeUnderReview
Dec 23, 2014
Project Member #2 David.Os...@gmail.com
(No comment was entered for this change.)
Cc: david.pu...@sonymobile.com
Dec 23, 2014
Project Member #3 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.11
Apr 16, 2015
Project Member #4 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting