| Issue 3020: | When pushing a change for review and adding %l=Verified+1 there is no comment about the label being added | |
| 2 people starred this issue and may be notified of changes. | Back to list |
************************************************************ ***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW ***** ***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL ***** ***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC. ***** ***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS! ***** ************************************************************ Affected Version: master What steps will reproduce the problem? 1. push changes with git push origin HEAD:refs/for/master%l=Verified+1 What is the expected output? What do you see instead? The Verified+1 label is added on the changes but there is no comment added. Please provide any additional information below. Not sure if this behaviour is intentional.
Nov 19, 2014
Project Member
#1
david.pu...@sonymobile.com
Cc:
David.Os...@gmail.com
Nov 19, 2014
I see, you mean: Patch Set 1: Verified+1 is missing. I will look into it.
Nov 19, 2014
Yes, this is intentional. This code path is calling:
ApprovalsUtil.addApprovals(db, update, labelTypes, newPatchSet, info,
changeCtl, approvals);
method in both cases: when pushing a new change and when pushing a new patch set for an existing change. In both cases no change messages are inserted. So i tend to say: Works as designed. That still leaves room for improvement, though.
Status:
AwaitingInformation
Dec 15, 2014
Even if it works as designed according to the code, I think it is a bug and should be fixed.
Oct 13, 2015
(No comment was entered for this change.)
Labels:
FixedIn-2.11.4
|
|
| ► Sign in to add a comment |