My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3020: When pushing a change for review and adding %l=Verified+1 there is no comment about the label being added
2 people starred this issue and may be notified of changes. Back to list
Status:  Submitted
Owner:  ----
Closed:  Oct 13
Cc:  David.Os...@gmail.com


Sign in to add a comment
 
Project Member Reported by david.pu...@sonymobile.com, Nov 18, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: master

What steps will reproduce the problem?
1. push changes with git push origin HEAD:refs/for/master%l=Verified+1


What is the expected output? What do you see instead?

The Verified+1 label is added on the changes but there is no comment added.

Please provide any additional information below.

Not sure if this behaviour is intentional.
Nov 19, 2014
Project Member #1 david.pu...@sonymobile.com
(No comment was entered for this change.)
Cc: David.Os...@gmail.com
Nov 19, 2014
Project Member #2 David.Os...@gmail.com
I see, you mean:

Patch Set 1: Verified+1

is missing. I will look into it.
Nov 19, 2014
Project Member #3 David.Os...@gmail.com
Yes, this is intentional. This code path is calling:

  ApprovalsUtil.addApprovals(db, update, labelTypes, newPatchSet, info,
            changeCtl, approvals);

method in both cases: when pushing a new change and when pushing a new patch set for an existing change. In both cases no change messages are inserted. So i tend to say: Works as designed. That still leaves room for improvement, though.
Status: AwaitingInformation
Dec 15, 2014
Project Member #4 david.pu...@sonymobile.com
Even if it works as designed according to the code, I think it is a bug and should be fixed.

Oct 13, 2015
Project Member #5 zaro0508
Fix on stable-2.11: https://gerrit-review.googlesource.com/#/c/71407

Status: Submitted
Oct 13, 2015
Project Member #6 david.pu...@sonymobile.com
(No comment was entered for this change.)
Labels: FixedIn-2.11.4
Sign in to add a comment

Powered by Google Project Hosting