My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 301: prevent duplicate patches due to forgotten `git add`
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Oct 2012


Sign in to add a comment
 
Project Member Reported by m.bn...@gmail.com, Oct 13, 2009
If a patch is submitted as "--replace" that is identical to the patch that
was already there, I think it should be rejected to avoid spam and mistakes
(people forgetting to use `git add` first...not that I would have ever done
that!).
Nov 2, 2009
#1 sop+code@google.com
This is harder than it sounds.

It is completely valid to want to upload a new commit which has the same set of files 
as the prior patch set, but whose commit message is different.  E.g., perhaps the reviewer is happy with everything except the author's explanation of the change.

It is also completely valid to re-upload patch set 1's files to replace patch set 2.  
E.g. maybe the reviewer is flip-flopping and tells the author to go back to what he 
had in patch set 1.  To do that you'd have to upload the same tree as patch set 1, 
but the tree still differs from the current patch set, patch set 2.

I'm coding the check to require that either the tree (set of files) OR the commit 
message differs from the prior patch set.

Fixed by change I05e1582d132b9300dc47f1a6ef2f9d72d45b774a.
Summary: prevent duplicate patches due to forgotten `git add`
Status: Fixed
Labels: FixedIn-2.0.24
Oct 21, 2012
#2 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting