My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3: SSH username is not set on account creation
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Shawn Pearce <sop@google.com> on Mon Jan 12 09:51:55 PST 2009
Source: JIRA GERRIT-3
Affected Version: 2.0

The SSH username field of Account is not properly created when a new account
is created for a user.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Mon Jan 12 11:22:23 PST 2009

I can't reproduce this.

The import script from Gerrit1 to Gerrit2 populates the SSH username field.

The two locations where Account entities can be created use setPreferredEmail
(), which always sets the sshUserName if the input email is not null and
contains an "@" sign.
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by Wiktor Kwapisiewicz <wiktor.kwapisiewicz+jsac@gmail.com> on Tue Jan 13 09:09:44 PST 2009

I didn't use the import script, just logged in with my Google Account for the
first time.

I can't check it twice right now but maybe this issue is somehow connected
with GERRIT-4 (e-mail address was empty there and you said that
setPreferredEmail "always sets the sshUserName if the input email *is not
null* and contains an "@" sign.").
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Tue Jan 13 09:11:57 PST 2009

I think you are right; this must be connected with GERRIT-4.  If we don't get
email data from the OpenID provider than we have nothing to set either
preferred email or the SSH username by.
Sep 24, 2009
#4 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Tue Jan 13 09:12:24 PST 2009
Blockedon: 4
Sep 24, 2009
#5 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Thu Jan 15 12:24:37 PST 2009

Username is set when the user sets their own email, or if we get the email
from the OpenID provider.
Sep 24, 2009
#6 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Thu Jan 15 12:24:37 PST 2009

Fixed in version 2.0.
Status: Fixed
Sep 25, 2009
#7 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0
Oct 25, 2012
#8 sop@google.com
(No comment was entered for this change.)
Status: Released
Blockedon: -gerrit:4
Sign in to add a comment

Powered by Google Project Hosting