| Issue 2973: | Diff is automatically merged if +2 is given before Jenkins verify is complete | |
| 1 person starred this issue and may be notified of changes. | Back to list |
************************************************************ ***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW ***** ***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL ***** ***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC. ***** ***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS! ***** ************************************************************ Affected Version: 2.9.1 What steps will reproduce the problem? 1. Open the gerrit review and give +2 before Jenkins verify is complete 2. Jenkins verify completes and gives check 3. Changes are merged automatically without further user action What is the expected output? What do you see instead? I expect that the changes will not be merge until I excplitly click on the "Submit" button. Note that this behavior is inconsistent because if the Jenkins verify happens first then the +2 vote is given, the change is not automatically merged, but requires manual action to click "Submit". I believe it is preferable that the change never be automatically merged. Even if one user gives a +2 vote that does not mean that other reviewers will not find issues that need to be corrected before submit. Please provide any additional information below. Note that this is in the call_control repo.
Oct 17, 2014
Project Member
#1
edwin.ke...@gmail.com
Status:
AwaitingInformation
Feb 17, 2015
No answer after 4 months.
Status:
Invalid
|
|
| ► Sign in to add a comment |