My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2970: Css: Font line height in diff view cause invisible polish special chars
2 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Nov 2014


Sign in to add a comment
 
Reported by tomasz.k...@gmail.com, Oct 15, 2014
Affected Version: 2.9.1

What steps will reproduce the problem?
1. Open Side-by-Side Diff Screen

What is the expected output?
- I see polish special chars like: Ś, Ż, Ź, Ń... correctly

What do you see instead?
- I don't see dash/dot above Ś, Ż, Ź, Ń...

Please provide any additional information below.
- CSS hotfix: change "line-height:inherit" style for ".CodeMirror pre" to "line-height: 1.3em" fix this problem.
Oct 15, 2014
Project Member #2 edwin.ke...@gmail.com
Can't reproduce this on current master:
  http://i.imgur.com/g37nxHH.png

I checked it with Chrome and Firefox. Which browser do you use?
Oct 15, 2014
#3 tomasz.k...@gmail.com
Firefox 32.0.3

On screen red marked "Z" is "Ż".
gerrit.png
113 KB   View   Download
Oct 23, 2014
#4 tomasz.w...@skytechnology.pl
Hint, it can be broken by missing/invalid font-family set.
Kubuntu 14.04
Nov 5, 2014
Project Member #5 david.pu...@sonymobile.com
Reproducible for me on this change:

https://gerrit-review.googlesource.com/#/c/61324/1/.mailmap@5

with Chromium Version 37.0.2062.120 Ubuntu 12.04 (281580) (64-bit)

It is not reproducible on Chrome 38.0.2125.111 m, on Windows 7 Enterprise SP1.
Status: Accepted
Nov 18, 2014
Project Member #6 david.pu...@sonymobile.com
https://gerrit-review.googlesource.com/#/c/61712/
Status: ChangeUnderReview
Nov 19, 2014
Project Member #7 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.9.2
Nov 30, 2014
Project Member #8 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting