My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2959: Column guide is not correct depending on font settings.
1 person starred this issue and may be notified of changes. Back to list
Status:  Duplicate
Merged:  issue 2918
Owner:  ----
Closed:  Oct 2014


Sign in to add a comment
 
Reported by rbutterf...@google.com, Oct 13, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: (2.10-rc0-657-g7595f68) 

What steps will reproduce the problem?
1.  Open diff view in chrome or safari, wide enough to see column lines
2.
3.

What is the expected output? What do you see instead?

The column guide appears to be incorrect.  We have it set at 100 chars as per our coding standard, and the guide is off by 10 characters.  Examining in chrome, the guide appears to be done with a DIV set to 800 pixels, which from playing around with it looks like its just {expected char width} * {column count} where char width in this case is 8 pixels.  If I go into safari, the same effect is reproduced, however if I choose Safari's zoom by text option, you can see the text grow and shrink while the link remains fixed.  

It seems like the calculation for the line is off or some other metric needs to be introduced for its placement.

Please provide any additional information below.

Oct 22, 2014
Project Member #1 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Duplicate
Mergedinto: 2918
Sign in to add a comment

Powered by Google Project Hosting