| Issue 2955: | delete-project plugin UI: misleading button label, no safeguards, no way to set options for deletion | |
| 2 people starred this issue and may be notified of changes. | Back to list |
Affected Version: 2.9, 2.10 What steps will reproduce the problem? 1. Install delete-project plugin 2. Navigate to a project's page in Gerrit 3. Click the "Delete..." button What is the expected output? What do you see instead? Expected: a dialog allowing the user to set the "preserve repository" option and asking for confirmation, with "Proceed" and "Cancel" buttons. Only if "Proceed" is clicked the repo will be deleted. "Cancel" backs out. If the repo is deleted, the project list is loaded, not the just deleted project's page. Nice to have: if that dialog also already displays warnings against deletion (such as open changes) and then only offers the "Cancel" button. (Or, if doable without causing performance problems, disable the "Delete..." button up front if the repo can't be deleted. Or alternatively, give the user the possibility to set the "force" flag in that dialog if there are warnings.) Actual: the repository is deleted right away (if there are no open changes). After deletion, the project page is reloaded, but since the project doesn't exist anymore, I get a failure screen. Please provide any additional information below. I've filed this as a bug instead of as a feature request since a button labelled with "Delete..." *clearly* indicates that there will be an additional UI step before any action is taken. That this doesn't happen is a severe UI goof -- the UI is lying to the user. Since project deletion is not reversible, this is rather severe. And no, just changing the button label to "Delete!" is not an option. The ssh interface requires the --yes-really-delete parameter; the GUI interface should also require explicit confirmation.
Oct 11, 2014
#1
tw201...@gmail.com
Oct 14, 2014
> Actual: the repository is deleted right away (if there are no open changes). After deletion, the project page is reloaded, but since the project doesn't exist anymore, I get a failure screen. Something is wrong on your side. If i click "Delete..." popup button appears where additional input can be provied, as you would expect. And when i don't click on "Delete" button in popup (what you mean with proceed) nothing happens. And when i confirm by clicking on "Delete" button then i'm getting confirmation page and after confirming it, project list is loaded as you would expect. See screenshots [1], [2]. Tested on Gerrit master [3] and latest delete-project plugin [4]. [1] http://imgur.com/AQPibfE [2] http://imgur.com/QnlVjKq [3] b810da20531bbfa8bc8b1df3a8f2ea4f6a89ebb4 [4] a76aa58eb786f52491b0088132383c372b4fa894
Status:
AwaitingInformation
Oct 14, 2014
In that case I'll have to investigate more what might have gone wrong. Your links [3] and [4] give me 404's. Please correct; I'd like to see what you're referencing there. Maybe I installed the wrong thing? I got the plugin for our production Gerrit 2.9.1 from http://ci.gerritforge.com/view/Plugins-stable-2.9/job/Plugin_delete-project_stable-2.9/lastSuccessfulBuild/artifact/target/delete-project-2.9.jar Was that not the right jar? If so, where's the correct jar?
Oct 15, 2014
Strange - I cannot reproduce this anymore. My only guess at what happened is that somehow the JavaScript that should do that dialog did not get loaded. No idea why. How about creating that "Delete..." button disabled and enable it only in that JavaScript to prevent that kind of error? Otherwise, this can be closed as not reproducible. Issue 2956 can also be closed; I cannot reproduce that either anymore.
Feb 17, 2015
(No comment was entered for this change.)
Status:
CannotReproduce
Dec 9, 2015
I have had the same issue. And then I solved it. Here are details: I have installed the plugin via ssh, and I did not restart Gerrit after installing the plugin. I just waited some time to make sure that Gerrit reloaded the plugins (default is 1 minute, but in my case it was more like an hour). The behaviour I got when I deleted one of my projects at this point was identical to the one described in the initial post of this issue. Then, I restarted Gerrit. The behaviour I got when I deleted one of my other projects was identical to the what should happen, and happens in reply #2. I hope this helps. |
|
| ► Sign in to add a comment |