| Issue 2946: | Make it possible to hide Submit button if change isn't rebased | |
| 1 person starred this issue and may be notified of changes. | Back to list |
We use Gerrit to ensure that every change is code reviewed and compiled before it enter master repository. That ensures that master repository is always at least compiling. However, we have found that master build can get broken if change isn't rebased before it is submitted to master repository. It happens rarely but still can happen. Currently when Submit button is pressed, change is automatically merged to master repo. If merge is successful, Gerrit is happy even though there might be problems with compiling. What we want is to force people to rebase their change in Gerrit before submitting is possible. Rebase triggers another Jenkins build job and possible build errors are found already in review phase. I tried to check if prolog submit rules could help on this case but it seems that prolog engine doesn't receive facts that change isn't rebased: https://git.eclipse.org/r/Documentation/prolog-change-facts.html So, one possibility to implement this feature is to provide rebase information to Prolog engine. After that rules.pl could be modified to include also rebase information into decision logic. If there is some other way to solve our problem, I'm happy to hear about all options :)
Oct 6, 2014
Project Member
#1
edwin.ke...@gmail.com
Oct 6, 2014
Thanks for the tip. That worked quite good for our purposes. I didn't try that option since I thought it would disable also Rebase button from Gerrit and users should do rebasing locally before submitting change. Since that is not the case, I think this feature request is not valid anymore.
Oct 6, 2014
(No comment was entered for this change.)
Status:
Invalid
|
|
| ► Sign in to add a comment |