My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2918: SideBySide2: Margin line is shown too far to the right
3 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  sop@google.com
Closed:  Nov 2014


Sign in to add a comment
 
Project Member Reported by david.pu...@sonymobile.com, Sep 18, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: master

What steps will reproduce the problem?
1. Set line length to 80 in diff prefs
2. Upload a change with lines 80 or more columns long
3.

What is the expected output? What do you see instead?

Expected: the margin line is shown at 80 columns.

Actual: the margin line is shown further to the right

Please provide any additional information below.

line-width.png
110 KB   View   Download
Sep 18, 2014
Project Member #1 david.pu...@sonymobile.com
Experimenting with the width setting shows that the calculated position for the margin is 10% too high.  I.e. if you set 20 columns, it displays at 22.  If you set 40, it displays at 44, etc.



Oct 22, 2014
Project Member #2 david.pu...@sonymobile.com
 Issue 2959  has been merged into this issue.
Oct 28, 2014
Project Member #3 david.pu...@sonymobile.com
 Issue 2986  has been merged into this issue.
Nov 6, 2014
#4 sop@google.com
https://gerrit-review.googlesource.com/61381
Status: ChangeUnderReview
Owner: sop@google.com
Nov 7, 2014
Project Member #5 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.9.2
Nov 30, 2014
Project Member #6 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting