| Issue 2916: | Ctrl-F while reviewing a change is implemented by some Java regexp instead of the browser implementation of search | |
| 1 person starred this issue and may be notified of changes. | Back to list |
************************************************************ ***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW ***** ***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL ***** ***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC. ***** ***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS! ***** ************************************************************ Affected Version: What steps will reproduce the problem? 1. Browse to a file in a patch set with a change 2. Want to search the web page for a string, so use keyboard shortcut Ctrl-F to open search. 3. Java regexp search appears in top right of the diff-showing widget, so enter search string and hit return 4. Search box disappears, so you can't keep pressing return to scroll through the matches like the native browser might implement. Neither does the java regexp search retain the last search string by default What is the expected output? What do you see instead? Ctrl-F should not be intercepted by the widget showing the diff. Leave that to the browser. Please provide any additional information below. Gerrit 2.9.1, Chrome 36.0.1985.143 Ubuntu 14.04
Sep 18, 2014
#1
dborowitz@google.com
Sep 18, 2014
Thanks for the response. I don't mind whether the search is regex or plain, but having the browser implementation of search intercepted is disconcerting because it breaks the UI experience for me. However, on standard Mac, cmd-F for search does not get intercepted, either, and that user wouldn't necessarily try Ctrl-F ever. You have a tough job :-( I now see in the '?' documentation that '/' does a cross-platform search, and 'n' will repeat the Javascript forward search (and works well enough to let me do what I was originally wanting to do), but so far 'p' to search backwards doesn't go back to the previously-found forward-sense match like I expected. Maybe it repeats a backward search? It's hard for me to say whether I was originally making a bug report or a feature request without knowing the implementation details of whether the diff-widget rendering is client or server-side :-) Intercepting the keyboard shortcut for the browser's search function when the CodeMirror widget has the focus would make some sense, but you might not be able to do that. Instead, having Ctrl-F do the same thing on all browsers is not really something you could call a bug, either... I'm happy to call this resolved - there actually is a search interface that lets me repeat a search, which is what I originally wanted and found hard to do.
Sep 22, 2014
Closing according to previous comment from submitter.
Status:
WontFix
|
|
| ► Sign in to add a comment |