My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2902: its-bugzilla not notifying Bugzilla 4.4.3+ of patches
3 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Jan 2015


Sign in to add a comment
 
Reported by act...@aricgardner.com, Sep 12, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: All versions of its-bugzilla

What steps will reproduce the problem?
1. build and install its-bugzilla (issue linking in gerrit works)
2. Deploy a patch closing a linked  issue
3 . its-bugzilla cannot post to bugzilla 4.4.3 or above

What is the expected output? What do you see instead?

Caused by: org.apache.xmlrpc.XmlRpcException: You must log in before using this part of Bugzilla.

Please provide any additional information below.

Cookies have been removed from recent versions of bugzilla in favor of token passing. When installing the plugin through gerrit init, the login test works, (returns 200) However (I believe that) the plugin receives a token rather than the cookie it expects, so later on, posting fails. 

Here is the relevant ticket from wikimedia's bugzilla: https://bugzilla.wikimedia.org/show_bug.cgi?id=65370

I've attached the source for their patch to this ticket,
inside the archive is the j2bugzilla patch.  this is the issue it addresses:

j2bugzilla/hooks-bugzilla plugin that allows token passing for bugzilla-4.4.4 instead of using sessions.

There is however a newer version of j2bugzilla, and in fact wikimedia is still using hooks-bugzilla, itself depreciated in favour of its-bugzilla.
So creating a patch is not straightforward (especially since I am not a java developer)

We use Gerrit and Bugzilla extensively at my work and I feel like this plugin would be very useful for the developers going forward. 

Regards, 
Aric 

hooks-bugzilla-for-bugzilla-4.4.3.tar.gz
419 KB   Download
Sep 26, 2014
#1 gerald.c...@gmail.com
It looks like j2bugzilla fixed this in 2.2.1 by handling the tokens internally (i.e. without requiring any API changes). I updated the version dependency in plugins/hooks-bugzilla/pom.xml and rebuilt hooks-bugzilla.jar, and actions are working again in our environment.

diff --git a/pom.xml b/pom.xml
index 0bbb64a..adf5ff7 100644
--- a/pom.xml
+++ b/pom.xml
@@ -101,7 +101,7 @@ limitations under the License.
     <dependency>
       <groupId>com.j2bugzilla</groupId>
       <artifactId>j2bugzilla</artifactId>
-      <version>2.2</version>
+      <version>2.2.1</version>
     </dependency>
     <dependency>
       <groupId>org.slf4j</groupId>

Sep 28, 2014
#2 act...@aricgardner.com
Thank you Gerald,

Built cleanly for me as well, with + <version>2.2.1</version>, I'll probably get around to testing this on Monday.

Here's my process for building its-bugzilla against 2.9, could be wrong I'm not a java guy. https://gist.github.com/Aricg/ea399262ef07561e295b 


Jan 25, 2015
Project Member #3 zaro0508
fixed in change https://gerrit-review.googlesource.com/61241
Status: Released
Sign in to add a comment

Powered by Google Project Hosting