My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2863: Better to have Publish and Submit button besides Publish Comments button after making Non-Author-Code-Review config change
2 people starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  ----
Closed:  Feb 2015


Sign in to add a comment
 
Reported by anantha....@gmail.com, Aug 26, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:
Gerrit v2.8.1 deployed on Apache Tomcat v7.0 on Windows Server 2008 R2 edition

What steps will reproduce the problem?
1. Create the rules.pl file with the following content in All-Projects.git's refs/meta/config branch.

submit_filter(In, Out) :-
  gerrit:default_submit(X),
  In =.. [submit | Ls],
  add_non_author_approval(Ls, R),
  Out =.. [submit | R].
add_non_author_approval(S1, S2) :-
  gerrit:commit_author(A),
  gerrit:commit_label(label('Code-Review', 2), R),
  R \= A, !,
  S2 = [label('Non-Author-Code-Review', ok(R)) | S1].
add_non_author_approval(S1, [label('Non-Author-Code-Review', need(_)) | S1]).


2. Create a review and add a reviewer.
3. Reviewer does not get 'Publish and Submit' button. The reviewer has to vote +2 for CR, +1 for V and click on 'Publish Comments'. Then again click on 'Review' button to get 'Publish and Submit' button.

Is this deliberately done..? 

What is the expected output? What do you see instead?
However, I think it will be easy for the Reviewer to have 'Publish and Submit' button besides 'Publish Comments' button.

Please provide any additional information below.

Feb 17, 2015
Project Member #1 edwin.ke...@gmail.com
The old change screen is removed with upcoming Gerrit 2.11 and on the new change screen there is no 'Publish and Submit' button.
Status: WontFix
Sign in to add a comment

Powered by Google Project Hosting