My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 285: Request 'git pull' line to be included in gerrit code review emails.
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  sop+code@google.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by San.Me...@gmail.com, Sep 29, 2009
It would really be great if the git pull line for a change was included in 
the gerrit code review emails.

thanks
-san

Sep 29, 2009
#1 sop+code@google.com
This has proven to be much more difficult to implement than I had hoped.

I can't just put an @Inject SshInfo into the NewChangeSender and ReplacePatchSetSender
classes; these are bound in Guice via GerritGlobalModule which does not have access
to the SshInfo instance.  Unfortunately that means I have to pull these down into a
different module which is loaded into the web and ssh injectors separately.  Yikes.
Status: Accepted
Owner: s...@google.com
Sep 29, 2009
#2 sop+code@google.com
Eh, fixed by Ife86d368944dc7a52c701a7ec306155cd0ed50c8
Status: Fixed
Labels: FixedIn-2.0.22
Sep 29, 2009
#3 sop+code@google.com
Dang, worked locally, so I built .22 and uploaded to rsac, where it promptly failed
to work as expected.
Status: Started
Labels: -FixedIn-2.0.22
Sep 29, 2009
#4 sop+code@google.com
And the one missing was fixed by I376c7deda08a04bcda5813be14c77bfba95cb9d8
Status: Fixed
Labels: FixedIn-2.0.23
Oct 21, 2012
#5 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting