My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2843: Post button changes position shortly after appearing
1 person starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by dan...@gmail.com, Aug 19, 2014
Affected Version:
2.9

What steps will reproduce the problem?
1. Use Gerrit over a connection with high latency (Australia <-> USA, or over a poor quality 3G link, or ...)
2. Use the new change screen
3. Review a patch, write some inline comments
4. Go up to the main change screen and hit Reply to send your comments
5. Move your mouse down to the Post button, which initially appears immediately below the score radio buttons, and try to click it
6. Discover that Gerrit asynchronously loaded the inline comments and now the Post button has shifted downwards, instead there is a link to a file in the patch where your mouse is
7. Become enraged, wait for Gerrit to load the diff, then go back to step 4 and repeat

What is the expected output? What do you see instead?
Having the Post button change position a second or two after appearing is a really frustrating user experience. Ideally UI elements would never change position depending on the results of an AJAX call. In this case there are a few possible fixes:
* show inline comments below the Post button instead of above it
* avoid showing the Reply pop-up until the AJAX calls to populate it are all done
* as a last resort, you could disable the Post button until it has finished moving around the page

Please provide any additional information below.
When doing any UI work I strongly suggest the Gerrit developers use a browser extension which introduces some artificial latency for AJAX requests. It makes the behaviour of the UI more realistic (developers will always be talking to localhost but real users always have some amount of latency, sometimes a lot).
Sign in to add a comment

Powered by Google Project Hosting