My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2801: "gerrit review" SSH command doesn't send notifications anymore in Gerrit 2.9
3 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Aug 2014


Sign in to add a comment
 
Reported by dan...@gmail.com, Jul 27, 2014
Affected Version:
2.9

What steps will reproduce the problem?
1. Use "gerrit review" SSH command to add a review comment, without passing the --notify option

What is the expected output? What do you see instead?
Up until Gerrit 2.8.5 this sent notifications to all reviewers like a normal comment.
After upgrading to Gerrit 2.9 no notifications are sent for the comment, and a log message like this appears:

WARN  com.google.gerrit.server.change.PostReview : notify = null; assuming notify = NONE

I'm guessing that a default of --notify=ALL is not being populated correctly somewhere along the line.
Aug 15, 2014
Project Member #2 huga...@gmail.com
(No comment was entered for this change.)
Status: ChangeUnderReview
Aug 21, 2014
Project Member #4 huga...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.9.1
Sep 11, 2014
Project Member #5 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting