************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC. *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS! *****
************************************************************
Affected Version: 2.8.6.1
What steps will reproduce the problem?
Invocations for the topic-changed hook does not contain any commit id.
What is the expected output? What do you see instead?
A commit id is supplied.
Please provide any additional information below.
Without the COMMIT identifier several options commonly used from a hook become impossible.
For example, there is no way to do a review operation, to set labels, since that operation takes either a COMMIT id or a CHANGE + Patchset id's.
According to the documentation, set-reviewers should also not be possible, since it requires a COMMIT identifier, however, for the time being appears to accept a CHANGE identifier.
From a hook writers perspective, it is becoming more more complicated to remember whether a CHANGE id uniquely identifies a change. In many instances it doesn't, since a CHANGE id could be present on more than one branch and in more than one project.
In this respect, the missing COMMIT id now requires any hook writer that is working with this particular hook, to translate project/branch/CHANGE into a COMMIT id. Although, presumably the only way to do this at this time is to go via an SSH query on change:x and then take the supplied project/branch details from the topic-changed invocation to filter out any non-interesting changes that have the same CHANGE id.