My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2773: Wrong Commiter Id and Commit Date
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  sop@google.com
Closed:  Aug 2014


Sign in to add a comment
 
Reported by rlu...@google.com, Jul 10, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:
2.9-rc2-661-g1a9d928

What steps will reproduce the problem?
I have not been able to narrow down when it occurs but the last few patches we submitted through gerrit submit button have the wrong Committer (listed as Gerrit Code Review) and more important for us the wrong commit date.

Look at https://gwt-review.googlesource.com/#/c/8203/ where the commit date predates the patch.

What is the expected output? What do you see instead?
The person who pressed submit to be the committer and the moment that the submit is pressed as the commit date.

Please provide any additional information below.

Aug 20, 2014
#1 sop@google.com
This is clearly a bug in the cherry pick code within Gerrit. Another recent case:

  https://gwt-review.googlesource.com/#/c/8793/

The cherry pick code must be grabbing the server's PersonIdent and retaining it, so the timestamp is always as of server startup (or first cherry pick setup) and not current time.
Status: Accepted
Owner: sop@google.com
Aug 20, 2014
#2 sop@google.com
https://gerrit-review.googlesource.com/59404 Fix stale dates in committer field
Status: ChangeUnderReview
Aug 20, 2014
Project Member #3 david.pu...@sonymobile.com
https://gerrit-review.googlesource.com/#/c/59415/
Status: Submitted
Labels: FixedIn-2.9.1
Aug 27, 2014
#4 rlu...@google.com
Thanks for the fix. Is there a chance that you can apply a retroactive fix?

I mean some of the commit dates in the repo are incorrect but they could be fixed by using the date when the review was submitted (which seems to be available when looking at the review).

The reason the commit date is important to us (the GWT project) is that is extensively used in our performance regression monitoring systems.

Thanks.
Aug 27, 2014
#5 sop@google.com
Changing the dates requires rewriting the history, changing all current SHA-1s.
We would also have to ban the old SHA-1s, forcing users to rebase their pending
CLs onto the new history.

So probably not.
Sep 11, 2014
Project Member #6 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting