My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 277: On a particular compare of old/new version the comment count is wrong or comments are displayed
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Wink Saville <wink@saville.com> on Wed Sep 09 10:12:40 PDT 2009
Source: JIRA GERRIT-278

In the change patch set 1 has 2 comments. Then a second patch was uploaded
and the file compare page shows that patch set 2 also has two comments but
does not show any.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Wed Sep 09 10:38:09 PDT 2009

In the case you pointed out to me, the aggregation under Patch History is
correct, both patch sets have 2 comments.  Unfortunately the UI isn't
displaying the 2 comments for patch set 2.

According to the database, the two missing comments have a parent comment
which does not exist in patch set 2, but do exist in patch set 1.  How the
heck did John manage to create two comments on patch set 2 in reply to two
comments on patch set 1?
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Wed Sep 09 15:21:14 PDT 2009

Fixed in version 2.0.21.
Status: Fixed
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Wed Sep 09 15:21:14 PDT 2009

Fixed by I0fd7180474381993d8ae5ce1dd65416d4234e220
Sep 25, 2009
#4 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.21
Oct 21, 2012
#5 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting