My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2742: Submit button in commit message editor should enable after changing text
3 people starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  ----
Closed:  Apr 2015


Sign in to add a comment
 
Reported by krinklemail@gmail.com, Jun 26, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:

What steps will reproduce the problem?
1. Copy characters into clipboard
2. Edit commit message
3. Select characters by double clicking a sequence
4. Paste

What is the expected output? What do you see instead?

The submit button should enable so that I can save the change. Instead it stays disable until I click out and back in the textarea again


Please provide any additional information below.

This happens a lot when changing things like "Bug: 123" to "Bug: 124" where I just navigated to  bug 123  and found a reference to the more relevant  bug 124 . Copy the ID (or hash) and paste it in the editor.

It's probably being too oldfashioned and only listening for onkeyup, instead of the modern 'onchange' event (perhaps bind to onpaste as well).
Jun 26, 2014
#1 krinklemail@gmail.com
Affected Version: 2.8.1-2-g724b796 (gerrit.wikimedia.org)
Apr 28, 2015
Project Member #2 edwin.ke...@gmail.com
The commit message editor was removed in Gerrit 2.11. Editing the commit message is now done by using the inline edit feature [1].

[1] https://gerrit-review.googlesource.com/Documentation/user-inline-edit.html
Status: WontFix
Sign in to add a comment

Powered by Google Project Hosting