| Issue 274: | owners of changes lack patch_set_approval records | |
| 1 person starred this issue and may be notified of changes. | Back to list |
Reported by Shawn Pearce <sop@google.com> on Mon Aug 31 07:20:12 PDT 2009 Source: JIRA GERRIT-275 Affected Version: 2.0.19.2 When a user creates a change, we should ensure they have a patch_set_approval record for it, otherwise the change will not appear in their "Recently closed changes" list on their dashboard. ---- On Fri, Aug 28, 2009 at 14:33, Mark<grimm26@gmail.com> wrote: > On Fri, Aug 28, 2009 at 4:17 PM, Shawn Pearce <sop@google.com> wrote: >> >> On Fri, Aug 28, 2009 at 13:28, Luciano Carvalho<lscarval@gmail.com> >> >> wrote: >> >> > After we moved to 2.0.19.2, and started using LDAP, my Recently >> >> > closed list >> >> > doesn't show the changes I Abandoned or Merged anymore. >> >> Sounds like something is wrong with the patch_set_approvals records > > The change_ids (two abandoned changes) in question are not present in > patch_set_approvals. That would do it. We don't write the record there unless the user publishes comments on the change. If they abandon it without doing that, yea, it won't show. That might also explain the merged ones, if the user didn't publish comments on those, we didn't write a patch_set_approvals record for them, so it wouldn't show. Hmmph. The latter is probably a bug, you should see your merged commits, even if you didn't publish comments on it.
Nov 21, 2009
(No comment was entered for this change.)
Owner:
s...@google.com
|
|
| ► Sign in to add a comment |
Owner: s...@google.com