My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2714: Publish and Submit should not work/be available if there is a -2 review.
1 person starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  ----
Closed:  Jun 2014


Sign in to add a comment
 
Reported by A.G.Ligh...@gmail.com, Jun 12, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: 2.8.1

What steps will reproduce the problem?
1.give a review a -2
2.click publish and submit


What is the expected output? What do you see instead?
Either the Publish and Submit button should be grayed out, or an error dialogue pops up saying that you cannot submit when you have a -2 review or at the least bring up a warning/secondary affirmation dialogue box "You gave this a -2 review, are you sure you want to submit to the repository"
Or 
just change the text on the button to "Publish review and submit code to repository"


Please provide any additional information below.

If a person is new to the system and doesn't understand that publish submit is pushing the code, you can push code into your repo you don't intend to.  additionally if you wanted to go back and fix the code and re-post it in line you can't because it's merged in. also a person can't go back and change the -2 to a +2 if they decide to keep the code as is.

Jun 13, 2014
Project Member #1 edwin.ke...@gmail.com
> If a person is new to the system and doesn't understand that publish submit
> is pushing the code, you can push code into your repo you don't intend to.
No. If there is a -2 vote the submit fails and the user will get an error when clicking on 'Publish and Submit'.

I agree that the 'Publish and Submit' button should be only enabled if the change is submittable, however this affects only the old change screen and we are not doing any further fixes for this old change screen. The new change screen (fully available with 2.9, beta in 2.8) doesn't have a 'Publish and Submit' button and is not suffering from this issue.
Status: WontFix
Sign in to add a comment

Powered by Google Project Hosting