My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2693: REST CommentInfo entity missing reply comments
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Jun 2014


Sign in to add a comment
 
Project Member Reported by zaro0508, Jun 1, 2014
The CommentInfo entity from the List Comment REST API does not contain the general reply message.   It only contains inline comments.

Affected Version: 2.8 and master

What steps will reproduce the problem?
1.  Create a change
2.  Make an inline comment 
3.  Click reply button and add a general message to in the reply.
4.  Post the reply 
5.  Use the REST api (i.e. List Comments) to retrieve the comments from this change

What is the expected output? What do you see instead?
I would expect to see all comments for the patch set.  The REST call only returns the inline comments.

Please provide any additional information below.
You can see an example of that here:
https://review.openstack.org/changes/Ia0d6570e9aae55ceadf076716fc8ad7688ff6214/revisions/3/comments

The returned info is missing this comment: 
Patch Set 3: Looks good to me, but someone else must approve
Looks good, nice to have the additional tests as well.

Jun 2, 2014
Project Member #1 David.Os...@gmail.com
I don't think this is a bug. And if, onlyin the documentation. We should probably be more precisely on what that REST endpoint supposed to do: only return file comment, not change messages.

To obtain change messages, use:

 GET /changes/link:#change-id[\{change-id\}]/detail

Background: there are two different tables

* PATCH_COMMENTS for storing comment in files
* CHANGE_MESSAGES for storing general change messages

It makes sense to me and separate concerns and apply KISS principle:
to return just file comments in the comments endpoints.
Status: AwaitingInformation
Jun 2, 2014
Project Member #2 zaro0508
Thanks for pointing out David.  This separation makes sense from architecture POV.  It was confusing because the Gerrit web client presents file comments and change messages as the same, just comments.  Anyways, it would be nice for docs to be more clear.   I'll mark this issue as invalid and I'll make an update to the docs to make it more explicit.
Status: Invalid
Oct 20, 2014
Project Member #3 david.pu...@sonymobile.com
https://gerrit-review.googlesource.com/#/c/57604/
Status: Submitted
Labels: FixedIn-2.10
Jan 27, 2015
Project Member #4 ziv...@gmail.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting