My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2662: Showing different files after comparing patch sets with no difference result
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  May 2014


Sign in to add a comment
 
Reported by jongrak....@lge.com, May 15, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: 2.9-rc1-646-gb7fd8de (new UI)

What steps will reproduce the problem?
1. Select any gerrit review having at least two patch sets
2. Select a file and compare between two patch sets with no difference
3. Press up arrow to go back to previous page

What is the expected output? What do you see instead?
The gerrit message is correct but file list show different files.

Please provide any additional information below.

May 16, 2014
Project Member #1 David.Os...@gmail.com
I don't quite understand your description. 

In [1] in ps 3 the file ChangeDataSource.java wasn't changed. So if you:

1. Compare ps 3 against Base, then the file is shown
2. Select the file and open Side by side view
3. Change patch set to compare against on the left side: 2
4. Message No differences is shown
5. Press up arrow (or 'u' key)
6. Change screen shown
7. Compare "Diff against" revision Drop down is preserved to be 2
8. As expected ChangeDataSource.java is not listed because it wasn't changed in patch set 3 compared to patch set 2.

[1] https://gerrit-review.googlesource.com/57251
Status: AwaitingInformation
May 16, 2014
#2 jongrak....@lge.com
Hi, please check below reproduction steps using [1].

1. Clicked [1] and I got below file list.
   .../DataSource.java
   .../ChangeDataSource.java
2. Select ".../ChangeDataSource.java"
   (Right side is on patch set 3 and left on base
3. Select patch set 2 on left side and confirmed "No difference" is shown
4. Press up arrow then I got the below file list which is different from #1
   ".../DataSource.java"

This issue doesn't happen with old UI.




May 17, 2014
Project Member #3 David.Os...@gmail.com
As i wrote in my description:

 8. As expected ChangeDataSource.java is not listed because it wasn't changed in patch set 3 compared to patch set 2.

You are missing one point: Change Screen contains "Diff against:" drop down. When select ".../ChangeDataSource.java" in you klast description, "Diff against:" value was Base. When you change the "Diff against:" in Side By Side screen, the value is preserved when you returns back to change screen.

That a feature and not in bug. There is no point to compare that feature with the old change screen, because it works completely differently: all patch sets are shown on one page.
May 19, 2014
#4 jongrak....@lge.com

Thank you for the detail explanation on the new feature which I wasn't noticed and I understand the "Diff against:" was preserved when I returned back to change screen.

But I'm still wondering if below is the expected behavior.

1/ Goto https://gerrit-review.googlesource.com/57251 and confirm below file list
   .../DataSource.java
   .../ChangeDataSource.java

2/ Select "3:6b1e3b" in "Diff against:" then below is the file list
   .../HttpPluginServlet.java

I don't think "HttpLuginServlet.java" is related to the patch.

The example I described in #2 step 4 seemed not good because the file list in #2-4 that I thought was incorrect was one of the valid files in #2 step 1.

With other patch, I got completely unrelated file list.

May 19, 2014
Project Member #5 edwin.ke...@gmail.com
This is because there was a rebase in between. This is fixed by
 https://gerrit-review.googlesource.com/57086
Status: ChangeUnderReview
May 19, 2014
#6 jongrak....@lge.com
Thank you for the confirmation.
The patch in #5 seemed to be matched with what I observed.
May 20, 2014
Project Member #7 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.9
Jul 18, 2014
Project Member #8 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting