| Issue 2636: | bogus change dependencies after reordering changes | |
| 1 person starred this issue and may be notified of changes. | Back to list |
Affected Version: 2.9-rc1
What steps will reproduce the problem?
1. Create two subsequent commits ("one", "two"), push them to refs/for/master.
2. Create a third commit ("three"). Now your local history shows "one" <- "two" <- "three".
3. Reorder the commits (e.g., with "git rebase -i HEAD~3") in the order "one" (same position as before) <- "three" <- "two". Push HEAD:refs/for/master.
4. Inspect the change dependencies as shown in the Change view under "Dependencies".
Expected:
"one" should show (Depends on) "(None)" / (Needed by) "three"
"three" should show (Depends on) "one" / (Needed by) "two"
"two" should show (Depends on) "three" / (Needed by) "(None)"
Seen instead:
"one" is "Needed by" *both* "two" and "three"
"three" correctly depends on "one", and is needed by "two"
"two" correctly depends on "three", and is needed by "(None)" -- contradicting the dependencies shown by "one".
May 6, 2014
#1
icee...@googlemail.com
May 6, 2014
Well, then I'd call this at least "unexpected". The second push *does* change gerrit's meta data on "one": it seems to add the new dependency "one" <- "three" -- but fails to remove the old dependency "one" <- "two". I can't see why this partial dependency update should be desirable. |
|
| ► Sign in to add a comment |