My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 262: --re=user no longer works in LDAP environments
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Shawn Pearce <sop@google.com> on Mon Aug 24 14:31:36 PDT 2009
Source: JIRA GERRIT-263
Affected Version: 2.0.19

Prior to 2.0.19 --re=user would be expanded by auth.emailFormat, and then the
user would be located in the database using the expanded email address.
However in .19 it would be common to disable this setting, and instead load
the email address from LDAP.  This means --re=user wouldn't expand, and we
never match against an account.

The right fix here is to pass "user" down to the Realm instance, and let the
Realm expand it, which for an HTTP_LDAP environment user would be treated as a
username in the LDAP directory, and we should let the LDAP directory perform
the expansion for us, rather than doing it in Gerrit's database.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Mon Aug 24 15:36:49 PDT 2009

Fixed by I8c8d5ce9e5ac1cd1a8b1dc85422257b00e1114ab
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Mon Aug 24 15:36:49 PDT 2009

Fixed in version 2.0.19.1.
Status: Fixed
Sep 25, 2009
#3 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.19.1
Oct 21, 2012
#4 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting