My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2611: [new change screen] Hide custom footer when reviewing code
2 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by docw...@gmail.com, Apr 17, 2014
Affected Version: 2.8.3


What steps will reproduce the problem?
1. Create a large custom footer
2. Try to review code
3. Notice that the code is rather small.

What is the expected output? What do you see instead?

I expect the code in the diff to take up the whole screen.

Please provide any additional information below.

To fix this, don't display the custom footer when doing code reviews.

Adding additional classes on the body showing what "page" we're on would be helpful as well (e.g. code-review, project-list, change, etc.) as this could be fixed via CSS as well.

Aug 14, 2014
#1 tom...@gmail.com
This works in unified diff, but in side-by-side the footer is fixed to the bottom of the window. Please change so that side-by-side diff works just as unified diff for large footers.
Aug 14, 2014
#2 tom...@gmail.com
And problem is still present in 2.9 by the way.
Jun 15, 2015
#3 docw...@gmail.com
Still in 2.10
Sign in to add a comment

Powered by Google Project Hosting