My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 26: Limit the impact of all change RPCs in ChangeListService
  Back to list
Status:  WontFix
Owner:  sop+code@google.com
Closed:  Sep 2009


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Shawn Pearce <sop@google.com> on Fri Jan 16 18:17:45 PST 2009
Source: JIRA GERRIT-26
Affected Version: 2.0

ChangeListService's allOpenPrev, allOpenNext, allClosedPrev, allClosedNext
methods can generate queries which scan the changes table.  If the user is
anonymous, or even if they are logged in but the majority of the changes
aren't visible to the user these methods can take a long time to respond as
they may need multiple batches of data from the database in order to fill up
the page requested by the client.

We should try to detect if there is a good chance that for this user the
changes are spread very far apart and increase the size of the query window,
or simply reject the query request altogether (especially in the anonymous
user case).
Sep 24, 2009
#1 sop+code@google.com
This has not yet proven to be a problem, and may never be a problem.  Its also likely
to become moot as we move over to Gimd as a backend.  (Or, at least change the scope
of the problem to something quite different.)
Status: WontFix
Owner: s...@google.com
Sign in to add a comment

Powered by Google Project Hosting