My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2599: set-reviewers cannot add reviewers if any group contains more than addreviewer.maxWithoutConfirmation
1 person starred this issue and may be notified of changes. Back to list
Status:  Submitted
Owner:  ----
Closed:  Apr 2014


Sign in to add a comment
 
Reported by pol...@gmail.com, Apr 9, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:

What steps will reproduce the problem?
1. Create a group with more than 10 members, eg. largegroup
2. Post a new change for review
3. Using SSH gerrit set-reviewers --add largegroup

error: The group largegroup has 12 members. Do you want to add them all as reviewers?
fatal: one or more updates failed; review output above

What is the expected output? What do you see instead?

All members added to the review.

According to the documentation, the current problem is not meant to happen:

addreviewer.maxWithoutConfirmation

    The maximum number of reviewers a user can add at once by adding a group as reviewer without being asked to confirm the operation.

    If set to 0, the user will never be asked to confirm adding a group as reviewer.

    Default is 10.

    This setting only applies for adding reviewers in the Gerrit WebUI, ***but is ignored when adding reviewers with the set-reviewers command.***


Please provide any additional information below.

Apr 9, 2014
#1 pol...@gmail.com
As of 2.8-rc0, later versions not tested.
Apr 9, 2014
Project Member #2 edwin.ke...@gmail.com
https://gerrit-review.googlesource.com/55841
Status: ChangeUnderReview
Apr 9, 2014
Project Member #3 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.8.4
Sign in to add a comment

Powered by Google Project Hosting