| Issue 259: | Search for user name never has any results | |
| 4 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
Reported by David Brown <dab@android.com> on Tue Aug 18 15:52:43 PDT 2009 Source: JIRA GERRIT-260 Affected Version: 2.0.18 Environment: Linux, firefox 3.0.13 (This is with the gerrit running right now on android-git.corp.google.com: v2.0.18-24-gfac9a42) The hint text for the "search" box at the upper-right of the gerrit page says Change #, SHA-1 or user name but I can't get any "user name" search to work. I tried all of the following: dab dab@google.com David Brown David Brown <dab@google.com> but none have any results, even though I have lots of changes in the system.
Sep 24, 2009
#1
code-rev...@gtempaccount.com
Sep 24, 2009
Comment by David Brown <dab@android.com> on Tue Aug 18 16:45:43 PDT 2009 Cool -- thanks! And you don't even need the full email address; "owner:dab" works fine too. But yeah, there's definitely a discoverability problem the way it is now :-) It would probably be fine if searching for "<user>" was just shorthand for "owner:<user>", or else you could get fancier and show a dashboard-like page with both owner: and reviewer: results...
Sep 24, 2009
Comment by Shawn Pearce <sop@google.com> on Tue Aug 18 16:49:38 PDT 2009 I agree. Right now the search box is pretty bad, its parser is a very naive tokenizer thing that we don't want to keep going forward, and the logic for how we execute the search is, uh, how shall we say it, just plain ugly. I have a patch series that I've started to clean this up, with a formal language, and some way of handling untagged fields, so "dab" can be treated more like "owner:dab OR reviewer:dab". But its too far from completion to be ready to roll into a release just yet.
Sep 24, 2009
(No comment was entered for this change.)
Status:
Accepted
Owner: s...@google.com
Sep 24, 2009
(No comment was entered for this change.)
Cc:
d...@android.com
Oct 1, 2009
I was going to make a separate ticket for this, but it sounds like you're already working on it here. In addition to making the username search more flexible, I think it should allow you to search for changes by name. Advanced search options would be wonderful, too. Right now you don't know what changes are ready to be pushed. Somewhat related, pagination could be vastly improved. Right now all you get is a "Next =>", which doesn't indicate how many exist or how many pages.
Oct 1, 2009
(No comment was entered for this change.)
Cc:
anth...@bnovc.com
Oct 1, 2009
Pagination and such makes things more complex, because you need to materialize the whole result set to know the length. Or cache counters somewhere that can give you a reasonable estimate as to the full result set length. This is very expensive either way. Really what is holding back a lot of this search work is I want to integrate an engine like Apache Lucene which can perform decent full text search over fairly large data sets. To that, I had been waiting on moving the database to a Git backend, rather than a SQL backend, because I had planned to use a tool like Apache Lucene to implement the secondary indexes in the Git backend since Git has no natural concept of indexes like a SQL database has. So, this bug has been lagging.
Nov 12, 2009
To improve the user experience with a small patch the search comment could be changed from: "Change #, SHA-1 or user name" to "Change #, SHA-1, owner:email or reviewer:email"
Nov 12, 2009
Hint text modified as suggested in comment #9; delta is in change Ic81c461142741cba5b3f6975c1dd1620096e4954.
Status:
Started
Labels: FixedIn-2.0.25
Nov 21, 2009
(No comment was entered for this change.)
Owner:
s...@google.com
Dec 12, 2009
(No comment was entered for this change.)
Labels:
-FixedIn-2.0.25 FixedIn-2.1
Jul 1, 2010
Changing the hint text might help someone, but I totally missed it. I cannot get the "SHA-1" search to work, I tried "7d9e6dbbf1c81d31645957906c9b3b0caa803ca7" and "7d9e6d" but neither found change #1333.
Jul 18, 2010
As of 51d008d693226816380a97dc4575902a97103803 typing in an email address in the search box causes Gerrit to rewrite the query as "owner:EMAIL OR reviewer:EMAIL", showing anything the user has created or reviewed.
Status:
Fixed
Labels: -FixedIn-2.1 FixedIn-2.1.4
Mar 27, 2012
(No comment was entered for this change.)
Status:
Released
|
||||||||||
| ► Sign in to add a comment | |||||||||||