My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2551: Absolute URLs treated as relative URLs in the Top Level Menu
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Mar 2014


Sign in to add a comment
 
Reported by irb...@gmail.com, Mar 12, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:
Master

What steps will reproduce the problem?
1. Create a TopLevel menu extension with an absolute URL (http://google.com)
2. Deploy and click on the link
3. Get directed to http://<Gerrit_install>/http://google.com/

While this could be a problem on my deployment, I don't think so (I'm not running gerrit in a servlet container), and the a href is clearly pointing at http://localhost/http://google.com This might be related to commit 46a1ffb. 

I also tested this by deploying the cookbook plugin and going to Projects -> Browse Repositories
Mar 13, 2014
Project Member #1 David.Os...@gmail.com
Can reproduce with cookbook plugin: Projects -> Browse Repositories: Not found and trying to redirect to:

  https://example.com/https://gerrit.googlesource.com/
Status: Accepted
Mar 13, 2014
#2 irb...@gmail.com
I've uploaded an initial patch set for this at [1]. We can continue the discussion on Gerrit.

[1] https://gerrit-review.googlesource.com/#/c/55120/1
Mar 13, 2014
Project Member #3 david.pu...@sonymobile.com
https://gerrit-review.googlesource.com/#/c/55133/

Status: ChangeUnderReview
Mar 14, 2014
Project Member #4 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.9
Jul 18, 2014
Project Member #5 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting