My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 255: crash during upload
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Shawn Pearce <sop@google.com> on Tue Jul 28 15:57:34 PDT 2009
Source: JIRA GERRIT-256
Affected Version: 2.0.17

$ git push ssh://review.source.android.com:29418/tools/gerrit HEAD:refs/
changes/10817

crashes with an internal server error.  The server logs show:

sshd error (account XXXX): git-receive-pack '/tools/gerrit': fatal: internal
server error
java.lang.IllegalStateException: Stale RevFlags on
1cad122fa97861d9e18d1f75d8958888a23599ad
	at org.spearce.jgit.revwalk.MergeBaseGenerator.add(MergeBaseGenerator.java:
115)
	at org.spearce.jgit.revwalk.MergeBaseGenerator.init(MergeBaseGenerator.java:
91)
	at org.spearce.jgit.revwalk.StartGenerator.next(StartGenerator.java:89)
	at org.spearce.jgit.revwalk.RevWalk.next(RevWalk.java:381)
	at org.spearce.jgit.revwalk.RevWalk.isMergedInto(RevWalk.java:358)
	at com.google.gerrit.server.ssh.Receive$3.run(Receive.java:897)
	at com.google.gerrit.server.ssh.Receive$3.run(Receive.java:845)
	at com.google.gwtorm.jdbc.JdbcSchema.run(JdbcSchema.java:56)
	at com.google.gerrit.server.ssh.Receive.appendPatchSet(Receive.java:845)
	at com.google.gerrit.server.ssh.Receive.appendPatchSets(Receive.java:795)
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Tue Jul 28 16:02:31 PDT 2009

In this case, HEAD was 33fa6af6e752a7fce99655c49c9b9b2c466be384.
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Tue Jul 28 16:20:08 PDT 2009

This is a recent bug in JGit.

Commit 3ae30ae64d56113a71a07a3ff12d0af71cf538e2[1] releases a RevFlag that has
been marked on RevCommit instances, but never clears the flag.  This causes
the merge base computation to throw a state exception.

[1] http://repo.or.cz/w/jgit.git?a=commit;h=3ae30ae64d56113a71a07a3ff12d0af71cf538e2
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Tue Jul 28 16:45:11 PDT 2009
Sep 24, 2009
#4 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Wed Jul 29 08:53:54 PDT 2009

Fixed by https://review.source.android.com/10843
Sep 24, 2009
#5 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Wed Jul 29 08:53:54 PDT 2009

Fixed in version 2.0.18.
Status: Fixed
Sep 25, 2009
#6 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.18
Oct 21, 2012
#7 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting