My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2543: replication.jar has entries with total compressed size 51539759835?
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Jul 2014


Sign in to add a comment
 
Reported by maximili...@gmail.com, Mar 11, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: Gerrit 2.8.1
UnZip 6.00 of 20 April 2009, by Debian. Original by Info-ZIP.

What steps will reproduce the problem?
1. unzip gerrit-2.8.1.war
2. unzip -v WEB-INF/plugins/replication.jar

What is the expected output?

no core dump

What do you see instead?

Archive:  WEB-INF/plugins/replication.jar
 Length   Method    Size  Cmpr    Date    Time   CRC-32   Name
--------  ------  ------- ---- ---------- ----- --------  ----
    2252  Defl:N     1150  49% 2014-01-15 09:48 dc357e9e  com/googlesource/gerrit/plugins/replication/SecureCredentialsProvider.class
    1442  Defl:N      672  53% 2014-01-15 09:48 b4fa562e  com/googlesource/gerrit/plugins/replication/PushOne$2.class
    2197  Defl:N      892  59% 2014-01-15 09:48 bc790cc1  com/googlesource/gerrit/plugins/replication/PushResultProcessing.class
    1233  Defl:N      503  59% 2014-01-15 09:48 1e624921  com/googlesource/gerrit/plugins/replication/PushResultProcessing$NoopProcessing.class
    3293  Defl:N     1222  63% 2014-01-15 09:48 5c13e193  com/googlesource/gerrit/plugins/replication/OnStartStop.class
     494  Defl:N      271  45% 2014-01-15 09:48 cb140561  com/googlesource/gerrit/plugins/replication/RemoteSiteUser$Factory.class
    1245  Defl:N      589  53% 2014-01-15 09:48 784284ad  com/googlesource/gerrit/plugins/replication/ReplicationType.class
   19014  Defl:N     7619  60% 2014-01-15 09:48 ffc7c5c5  com/googlesource/gerrit/plugins/replication/Destination.class
    1435  Defl:N      769  46% 2014-01-15 09:48 81f5f26d  com/googlesource/gerrit/plugins/replication/PushOne$3.class
     559  Defl:N      317  43% 2014-01-15 09:48 beff003d  com/googlesource/gerrit/plugins/replication/SshModule.class
    1869  Defl:N      731  61% 2014-01-15 09:48 b0f6a3f0  com/googlesource/gerrit/plugins/replication/RemoteSiteUser.class
    3980  Defl:N     1304  67% 2014-01-15 09:48 0a66084f  com/googlesource/gerrit/plugins/replication/Destination$1.class
    1404  Defl:N      642  54% 2014-01-15 09:48 c7e981e3  com/googlesource/gerrit/plugins/replication/Destination$RetryReason.class
   26349  Defl:N     9897  62% 2014-01-15 09:48 edb4bb8a  com/googlesource/gerrit/plugins/replication/PushOne.class
    2532  Defl:N     1147  55% 2014-01-15 09:48 a82e71a5  com/googlesource/gerrit/plugins/replication/SecureCredentialsFactory.class
    1016  Defl:N      537  47% 2014-01-15 09:48 38d2d594  com/googlesource/gerrit/plugins/replication/ReplicationState$1.class
    1803  Defl:N      742  59% 2014-01-15 09:48 6d9f8bd1  com/googlesource/gerrit/plugins/replication/Destination$2.class
     400  Defl:N      209  48% 2014-01-15 09:48 08dffa84  com/googlesource/gerrit/plugins/replication/PushAll$Factory.class
    1004  Defl:N      505  50% 2014-01-15 09:48 a845c837  com/googlesource/gerrit/plugins/replication/PushOne$1.class
    1239  Defl:N      694  44% 2014-01-15 09:48 9dae5ccf  com/googlesource/gerrit/plugins/replication/ReplicationQueue$1.class
    1003  Defl:N      530  47% 2014-01-15 09:48 fc83f168  com/googlesource/gerrit/plugins/replication/Destination$3.class
     648  Defl:N      362  44% 2014-01-15 09:48 72ba6e54  com/googlesource/gerrit/plugins/replication/StartReplicationCapability.class
    2009  Defl:N      844  58% 2014-01-15 09:48 e40059c5  com/googlesource/gerrit/plugins/replication/WrappedLogger.class
    2763  Defl:N     1034  63% 2014-01-15 09:48 4324f574  com/googlesource/gerrit/plugins/replication/ReplicationModule.class
    4052  Defl:N     1664  59% 2014-01-15 09:48 19a63879  com/googlesource/gerrit/plugins/replication/PushAll.class
    1248  Defl:N      504  60% 2014-01-15 09:48 1ef0f26b  com/googlesource/gerrit/plugins/replication/PushResultProcessing$GitUpdateProcessing.class
    1683  Defl:N      670  60% 2014-01-15 09:48 3e1e25e8  com/googlesource/gerrit/plugins/replication/Destination$1$1.class
    1452  Defl:N      639  56% 2014-01-15 09:48 206bb16e  com/googlesource/gerrit/plugins/replication/ReplicationState$RefPushResult.class
    1879  Defl:N      674  64% 2014-01-15 09:48 9739b075  com/googlesource/gerrit/plugins/replication/Destination$1$2.class
    4234  Defl:N     1701  60% 2014-01-15 09:48 5879be68  com/googlesource/gerrit/plugins/replication/ReplicationState.class
    1181  Defl:N      567  52% 2014-01-15 09:48 cf037a37  com/googlesource/gerrit/plugins/replication/PushResultProcessing$1.class
    6275  Defl:N     2737  56% 2014-01-15 09:48 1107d4ce  com/googlesource/gerrit/plugins/replication/StartCommand.class
     526  Defl:N      265  50% 2014-01-15 09:48 7fb4853b  com/googlesource/gerrit/plugins/replication/PushOne$Factory.class
   21030  Defl:N     8686  59% 2014-01-15 09:48 dddadc9a  com/googlesource/gerrit/plugins/replication/ReplicationQueue.class
    3358  Defl:N     1456  57% 2014-01-15 09:48 71d3b5f6  com/googlesource/gerrit/plugins/replication/PushResultProcessing$CommandProcessing.class
   11190  Defl:N     4182  63% 2013-12-17 19:48 376e8b87  Documentation/config.md
     967  Defl:N      535  45% 2013-12-17 19:48 7b0d4c30  Documentation/about.md
    3310  Defl:N     1497  55% 2013-12-17 19:48 effd5ff5  Documentation/cmd-start.md
       0  Stored 4294967295   0% 2008-01-17 03:14 00000000  META-INF/
       0  Stored 4294967295   0% 2008-01-17 03:14 00000000  org/
       0  Stored 4294967295   0% 2008-01-17 03:14 00000000  org/apache/
       0  Stored 4294967295   0% 2008-01-17 03:14 00000000  org/apache/commons/
       0  Stored 4294967295   0% 2008-01-17 03:14 00000000  org/apache/commons/io/
       0  Stored 4294967295   0% 2008-01-17 03:14 00000000  org/apache/commons/io/comparator/
       0  Stored 4294967295   0% 2008-01-17 03:14 00000000  org/apache/commons/io/filefilter/
       0  Stored 4294967295   0% 2008-01-17 03:14 00000000  org/apache/commons/io/input/
       0  Stored 4294967295   0% 2008-01-17 03:14 00000000  org/apache/commons/io/output/
   11562  Defl:N     3964  66% 2008-01-17 03:14 5f2fcb9f  META-INF/LICENSE.txt
     178  Defl:N      132  26% 2008-01-17 03:14 b25fc07d  META-INF/NOTICE.txt
     988  Defl:N      545  45% 2008-01-17 03:14 06ab9962  org/apache/commons/io/comparator/DefaultFileComparator.class
    1855  Defl:N      915  51% 2008-01-17 03:14 373c3915  org/apache/commons/io/comparator/ExtensionFileComparator.class
    1070  Defl:N      607  43% 2008-01-17 03:14 5d8d37c2  org/apache/commons/io/comparator/LastModifiedFileComparator.class
    1620  Defl:N      818  50% 2008-01-17 03:14 7cb8d845  org/apache/commons/io/comparator/NameFileComparator.class
    1620  Defl:N      819  49% 2008-01-17 03:14 2e3e2587  org/apache/commons/io/comparator/PathFileComparator.class
     820  Defl:N      478  42% 2008-01-17 03:14 54a2d737  org/apache/commons/io/comparator/ReverseComparator.class
    1593  Defl:N      898  44% 2008-01-17 03:14 13d44a2b  org/apache/commons/io/comparator/SizeFileComparator.class
    2933  Defl:N     1256  57% 2008-01-17 03:14 bf439056  org/apache/commons/io/CopyUtils.class
    1040  Defl:N      565  46% 2008-01-17 03:14 04f9e5d4  org/apache/commons/io/DirectoryWalker$CancelException.class
    4106  Defl:N     1635  60% 2008-01-17 03:14 447c3243  org/apache/commons/io/DirectoryWalker.class
    5356  Defl:N     2238  58% 2008-01-17 03:14 ed4ee842  org/apache/commons/io/EndianUtils.class
    1580  Defl:N      648  59% 2008-01-17 03:14 32abd26a  org/apache/commons/io/FileCleaner.class
    1440  Defl:N      768  47% 2008-01-17 03:14 5e6be2a9  org/apache/commons/io/FileCleaningTracker$Reaper.class
    1131  Defl:N      552  51% 2008-01-17 03:14 6cbb1516  org/apache/commons/io/FileCleaningTracker$Tracker.class
    2736  Defl:N     1238  55% 2008-01-17 03:14 9b0af505  org/apache/commons/io/FileCleaningTracker.class
     761  Defl:N      394  48% 2008-01-17 03:14 813a4607  org/apache/commons/io/FileDeleteStrategy$ForceFileDeleteStrategy.class
    1611  Defl:N      828  49% 2008-01-17 03:14 6b9abd0e  org/apache/commons/io/FileDeleteStrategy.class
    1173  Defl:N      610  48% 2008-01-17 03:14 fce61487  org/apache/commons/io/filefilter/AbstractFileFilter.class
    1810  Defl:N      878  52% 2008-01-17 03:14 481d5921  org/apache/commons/io/filefilter/AgeFileFilter.class
    3164  Defl:N     1448  54% 2008-01-17 03:14 cefba51a  org/apache/commons/io/filefilter/AndFileFilter.class
    1179  Defl:N      543  54% 2008-01-17 03:14 e7169cc1  org/apache/commons/io/filefilter/CanReadFileFilter.class
     891  Defl:N      463  48% 2008-01-17 03:14 7aaae8f3  org/apache/commons/io/filefilter/CanWriteFileFilter.class
     406  Defl:N      216  47% 2008-01-17 03:14 eee4866e  org/apache/commons/io/filefilter/ConditionalFileFilter.class
    1652  Defl:N      796  52% 2008-01-17 03:14 fabd898b  org/apache/commons/io/filefilter/DelegateFileFilter.class
     771  Defl:N      435  44% 2008-01-17 03:14 3c68485f  org/apache/commons/io/filefilter/DirectoryFileFilter.class
    1030  Defl:N      549  47% 2008-01-17 03:14 b3cf5e53  org/apache/commons/io/filefilter/EmptyFileFilter.class
     872  Defl:N      460  47% 2008-01-17 03:14 7284609a  org/apache/commons/io/filefilter/FalseFileFilter.class
     707  Defl:N      388  45% 2008-01-17 03:14 581c58fe  org/apache/commons/io/filefilter/FileFileFilter.class
    5121  Defl:N     1583  69% 2008-01-17 03:14 e43c3151  org/apache/commons/io/filefilter/FileFilterUtils.class
     877  Defl:N      460  48% 2008-01-17 03:14 129a2d52  org/apache/commons/io/filefilter/HiddenFileFilter.class
     277  Defl:N      184  34% 2008-01-17 03:14 1ed73651  org/apache/commons/io/filefilter/IOFileFilter.class
    2672  Defl:N     1228  54% 2008-01-17 03:14 3406cda7  org/apache/commons/io/filefilter/NameFileFilter.class
    1329  Defl:N      653  51% 2008-01-17 03:14 ed84b089  org/apache/commons/io/filefilter/NotFileFilter.class
    3110  Defl:N     1436  54% 2008-01-17 03:14 c93a8e17  org/apache/commons/io/filefilter/OrFileFilter.class
    2704  Defl:N     1246  54% 2008-01-17 03:14 3df22976  org/apache/commons/io/filefilter/PrefixFileFilter.class
    1690  Defl:N      791  53% 2008-01-17 03:14 df9757e6  org/apache/commons/io/filefilter/RegexFileFilter.class
    1338  Defl:N      751  44% 2008-01-17 03:14 84e6cf4b  org/apache/commons/io/filefilter/SizeFileFilter.class
    2702  Defl:N     1242  54% 2008-01-17 03:14 41e0951c  org/apache/commons/io/filefilter/SuffixFileFilter.class
     868  Defl:N      459  47% 2008-01-17 03:14 fc9bbd41  org/apache/commons/io/filefilter/TrueFileFilter.class
    2778  Defl:N     1253  55% 2008-01-17 03:14 cbb6adb0  org/apache/commons/io/filefilter/WildcardFileFilter.class
    1841  Defl:N      941  49% 2008-01-17 03:14 14adf964  org/apache/commons/io/filefilter/WildcardFilter.class
   10065  Defl:N     5095  49% 2008-01-17 03:14 501162e5  org/apache/commons/io/FilenameUtils.class
    7538  Defl:N     3946  48% 2008-01-17 03:14 72943427  org/apache/commons/io/FileSystemUtils.class
   22288  Defl:N     9210  59% 2008-01-17 03:14 5e1d4b14  org/apache/commons/io/FileUtils.class
    2523  Defl:N     1486  41% 2008-01-17 03:14 770b5a4e  org/apache/commons/io/HexDump.class
    1299  Defl:N      666  49% 2008-01-17 03:14 b83544de  org/apache/commons/io/input/AutoCloseInputStream.class
    2338  Defl:N     1309  44% 2008-01-17 03:14 d7d137c2  org/apache/commons/io/input/CharSequenceReader.class
    1157  Defl:N      544  53% 2008-01-17 03:14 82149520  org/apache/commons/io/input/ClassLoaderObjectInputStream.class
     511  Defl:N      315  38% 2008-01-17 03:14 6185f286  org/apache/commons/io/input/ClosedInputStream.class
     597  Defl:N      322  46% 2008-01-17 03:14 4d83f1b1  org/apache/commons/io/input/CloseShieldInputStream.class
    1949  Defl:N      994  49% 2008-01-17 03:14 e099b39f  org/apache/commons/io/input/CountingInputStream.class
    1140  Defl:N      596  48% 2008-01-17 03:14 ddf78755  org/apache/commons/io/input/DemuxInputStream.class
    3186  Defl:N     1645  48% 2008-01-17 03:14 10454c81  org/apache/commons/io/input/NullInputStream.class
    3014  Defl:N     1561  48% 2008-01-17 03:14 6803bf1e  org/apache/commons/io/input/NullReader.class
    1454  Defl:N      655  55% 2008-01-17 03:14 f9d52452  org/apache/commons/io/input/ProxyInputStream.class
    1425  Defl:N      649  55% 2008-01-17 03:14 09d8284b  org/apache/commons/io/input/ProxyReader.class
    2849  Defl:N     1185  58% 2008-01-17 03:14 89a5fc1e  org/apache/commons/io/input/SwappedDataInputStream.class
    1501  Defl:N      773  49% 2008-01-17 03:14 5220de43  org/apache/commons/io/input/TeeInputStream.class
    3025  Defl:N     1442  52% 2008-01-17 03:14 bb63733a  org/apache/commons/io/IOCase.class
     819  Defl:N      433  47% 2008-01-17 03:14 953c6c76  org/apache/commons/io/IOExceptionWithCause.class
   11279  Defl:N     4229  63% 2008-01-17 03:14 2a273051  org/apache/commons/io/IOUtils.class
    2076  Defl:N     1124  46% 2008-01-17 03:14 313ab442  org/apache/commons/io/LineIterator.class
    4086  Defl:N     2243  45% 2008-01-17 03:14 94ca3037  org/apache/commons/io/output/ByteArrayOutputStream.class
     877  Defl:N      508  42% 2008-01-17 03:14 81a26d82  org/apache/commons/io/output/ClosedOutputStream.class
     609  Defl:N      323  47% 2008-01-17 03:14 8ad03e57  org/apache/commons/io/output/CloseShieldOutputStream.class
    1762  Defl:N      888  50% 2008-01-17 03:14 731ca1b1  org/apache/commons/io/output/CountingOutputStream.class
    2748  Defl:N     1320  52% 2008-01-17 03:14 5b229100  org/apache/commons/io/output/DeferredFileOutputStream.class
    1290  Defl:N      644  50% 2008-01-17 03:14 5d13ca2a  org/apache/commons/io/output/DemuxOutputStream.class
    4682  Defl:N     1607  66% 2008-01-17 03:14 f924b6d4  org/apache/commons/io/output/FileWriterWithEncoding.class
    5266  Defl:N     2393  55% 2008-01-17 03:14 613e6579  org/apache/commons/io/output/LockableFileWriter.class
     766  Defl:N      424  45% 2008-01-17 03:14 5c416dc1  org/apache/commons/io/output/NullOutputStream.class
    1059  Defl:N      480  55% 2008-01-17 03:14 5e8b613e  org/apache/commons/io/output/NullWriter.class
    1076  Defl:N      522  52% 2008-01-17 03:14 fbff81a1  org/apache/commons/io/output/ProxyOutputStream.class
    1331  Defl:N      588  56% 2008-01-17 03:14 7d5130f2  org/apache/commons/io/output/ProxyWriter.class
    1231  Defl:N      590  52% 2008-01-17 03:14 6496b547  org/apache/commons/io/output/TeeOutputStream.class
    1872  Defl:N      929  50% 2008-01-17 03:14 c3d71e64  org/apache/commons/io/output/ThresholdingOutputStream.class
       0  Stored 4294967295   0% 2008-01-17 03:14 00000000  META-INF/maven/
       0  Stored 4294967295   0% 2008-01-17 03:14 00000000  META-INF/maven/commons-io/
       0  Stored 4294967295   0% 2008-01-17 03:14 00000000  META-INF/maven/commons-io/commons-io/
   13166  Defl:N     2823  79% 2008-01-17 03:05 e8eb3d7e  META-INF/maven/commons-io/commons-io/pom.xml
     108  Defl:N       97  10% 2008-01-17 03:14 dd907ec6  META-INF/maven/commons-io/commons-io/pom.properties
    1379  Defl:N      467  66% 2014-01-15 09:48 5a74228e  META-INF/MANIFEST.MF
*** buffer overflow detected ***: unzip terminated
======= Backtrace: =========
/lib/x86_64-linux-gnu/libc.so.6(__fortify_fail+0x37)[0x7ff7f507ff47]
/lib/x86_64-linux-gnu/libc.so.6(+0x109e40)[0x7ff7f507ee40]
/lib/x86_64-linux-gnu/libc.so.6(+0x1092a9)[0x7ff7f507e2a9]
/lib/x86_64-linux-gnu/libc.so.6(_IO_vfprintf+0x4004)[0x7ff7f4fc19c4]
/lib/x86_64-linux-gnu/libc.so.6(__vsprintf_chk+0x94)[0x7ff7f507e344]
/lib/x86_64-linux-gnu/libc.so.6(__sprintf_chk+0x7d)[0x7ff7f507e28d]
unzip[0x40f515]
unzip[0x41134c]
unzip[0x41172f]
unzip[0x403fd7]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xed)[0x7ff7f4f9676d]
unzip[0x401e39]
======= Memory map: ========
00400000-00426000 r-xp 00000000 08:01 1967619                            /usr/bin/unzip
00625000-00626000 r--p 00025000 08:01 1967619                            /usr/bin/unzip
00626000-00627000 rw-p 00026000 08:01 1967619                            /usr/bin/unzip
00627000-00719000 rw-p 00000000 00:00 0 
02412000-02433000 rw-p 00000000 00:00 0                                  [heap]
7ff7f4470000-7ff7f4485000 r-xp 00000000 08:01 10227312                   /lib/x86_64-linux-gnu/libgcc_s.so.1
7ff7f4485000-7ff7f4684000 ---p 00015000 08:01 10227312                   /lib/x86_64-linux-gnu/libgcc_s.so.1
7ff7f4684000-7ff7f4685000 r--p 00014000 08:01 10227312                   /lib/x86_64-linux-gnu/libgcc_s.so.1
7ff7f4685000-7ff7f4686000 rw-p 00015000 08:01 10227312                   /lib/x86_64-linux-gnu/libgcc_s.so.1
7ff7f4686000-7ff7f4688000 r-xp 00000000 08:01 2383346                    /usr/lib/x86_64-linux-gnu/gconv/IBM866.so
7ff7f4688000-7ff7f4887000 ---p 00002000 08:01 2383346                    /usr/lib/x86_64-linux-gnu/gconv/IBM866.so
7ff7f4887000-7ff7f4888000 r--p 00001000 08:01 2383346                    /usr/lib/x86_64-linux-gnu/gconv/IBM866.so
7ff7f4888000-7ff7f4889000 rw-p 00002000 08:01 2383346                    /usr/lib/x86_64-linux-gnu/gconv/IBM866.so
7ff7f4889000-7ff7f4890000 r--s 00000000 08:01 2383327                    /usr/lib/x86_64-linux-gnu/gconv/gconv-modules.cache
7ff7f4890000-7ff7f4f75000 r--p 00000000 08:01 1972587                    /usr/lib/locale/locale-archive
7ff7f4f75000-7ff7f512a000 r-xp 00000000 08:01 10224540                   /lib/x86_64-linux-gnu/libc-2.15.so
7ff7f512a000-7ff7f532a000 ---p 001b5000 08:01 10224540                   /lib/x86_64-linux-gnu/libc-2.15.so
7ff7f532a000-7ff7f532e000 r--p 001b5000 08:01 10224540                   /lib/x86_64-linux-gnu/libc-2.15.so
7ff7f532e000-7ff7f5330000 rw-p 001b9000 08:01 10224540                   /lib/x86_64-linux-gnu/libc-2.15.so
7ff7f5330000-7ff7f5335000 rw-p 00000000 00:00 0 
7ff7f5335000-7ff7f5344000 r-xp 00000000 08:01 10227290                   /lib/x86_64-linux-gnu/libbz2.so.1.0.4
7ff7f5344000-7ff7f5543000 ---p 0000f000 08:01 10227290                   /lib/x86_64-linux-gnu/libbz2.so.1.0.4
7ff7f5543000-7ff7f5544000 r--p 0000e000 08:01 10227290                   /lib/x86_64-linux-gnu/libbz2.so.1.0.4
7ff7f5544000-7ff7f5545000 rw-p 0000f000 08:01 10227290                   /lib/x86_64-linux-gnu/libbz2.so.1.0.4
7ff7f5545000-7ff7f5567000 r-xp 00000000 08:01 10227309                   /lib/x86_64-linux-gnu/ld-2.15.so
7ff7f5738000-7ff7f573b000 rw-p 00000000 00:00 0 
7ff7f5764000-7ff7f5767000 rw-p 00000000 00:00 0 
7ff7f5767000-7ff7f5768000 r--p 00022000 08:01 10227309                   /lib/x86_64-linux-gnu/ld-2.15.so
7ff7f5768000-7ff7f576a000 rw-p 00023000 08:01 10227309                   /lib/x86_64-linux-gnu/ld-2.15.so
7fff0f760000-7fff0f781000 rw-p 00000000 00:00 0                          [stack]
7fff0f7ff000-7fff0f800000 r-xp 00000000 00:00 0                          [vdso]
ffffffffff600000-ffffffffff601000 r-xp 00000000 00:00 0                  [vsyscall]


Please provide any additional information below.

'jar tvf WEB-INF/plugins/replication.jar' works OK.

Mar 11, 2014
Project Member #1 jrn@google.com
Yep, I can reproduce this. Will file against Debian unzip.
Status: Invalid
Mar 12, 2014
#2 maximili...@gmail.com
And there's no chance the replication.jar is actually wrong?
How was it produced?
The others plugin jars can be listed fine.
This is the first time I encounter a core dump of unzip and I'm using it a lot for looking into jars.
Mar 12, 2014
#3 maximili...@gmail.com
Two more observations:
- Only the replication.jar has actual directory entries.  The other plugins bundled in the gerrit.war don't have any directory entries.  Directory entries are not needed here.
- The size of the directory entries are listed as 4294967295 (ffffffff, or -1).  Directory entries typically have size 0.

Mar 14, 2014
#4 maximili...@gmail.com
The same problem shows with 2.8.2 and 2.8.3.
As a matter of fact, the replication.jars of all versions since 2.8 show the problem.

How was the replication.jar built?

I'm using unzip on jars quite regularily for many years.  I can't remember unzip core-dumped on a jar ever.

IMO, the replication.jar is simply corrupt.

Why not build replication.jar properly?
Mar 14, 2014
Project Member #5 jrn@google.com
You're asking reasonable questions, but unzip is not supposed to overflow buffers even when given invalid input. That's a serious bug; thanks for finding it.
Mar 14, 2014
Project Member #6 jrn@google.com
There's a patch for the unzip bug upstream now. Reopening to deal with the remaining weirdness.
Summary: replication.jar has entries with total compressed size 51539759835? (was: unzip core dump on listing content of replication.jar)
Status: New
Mar 14, 2014
#7 maximili...@gmail.com
On Linux, you can easily fix the replication.jar using 'zip':

  zip -d replication.jar '*/'

Gets rid of all the directory entries.
Subsequent 'unzip -v' doesn't barf any longer.

Jul 14, 2014
Project Member #8 david.pu...@sonymobile.com
Problem here seems to be because the jar file contains all of the commons IO stuff.

This was not supposed to be included, and has been removed by [1] which will be in 2.9

[1] https://gerrit-review.googlesource.com/#/c/57750/

Status: Submitted
Labels: FixedIn-2.9
Jul 18, 2014
Project Member #9 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting