My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2527: [New change screen] No links to gitblit anywhere
2 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  May 2014


Sign in to add a comment
 
Reported by federico...@tiscali.it, Mar 7, 2014
Affected Version: 2.8.1-1-g83098d0

What steps will reproduce the problem?
1. Enable new change screen in preferences
2. Open a commit, like https://gerrit.wikimedia.org/r/#/c/116914/

What is the expected output? What do you see instead?
I expect to see links to gitblit, e.g. to the commit or commitdiff view. I instead don't see any way to reach gitblit.

Apr 30, 2014
Project Member #1 David.Os...@gmail.com
How this issue is related to Gerrit project? Is Gitblit plugin installed? 
Status: AwaitingInformation
Apr 30, 2014
#2 dborowitz@google.com
This sounds like a configuration problem on the Wikimedia side. The links to a properly configured repository browser are visible from both the new change screen and the new side-by-side diff screen (which is what I assume you mean by "commitdiff view").

https://gerrit-review.googlesource.com/56644
There is a "(gitiles)" link next to the commit SHA-1 under the commit mesage.

https://gerrit-review.googlesource.com/#/c/56644/2/Documentation/user-review-ui.txt
The "gerrit" and "Documentation" breadcrumbs on the top left both link to gitiles as well.
Apr 30, 2014
#3 nemow...@gmail.com
Thanks for your reply.

Yes, we have gitblit plugin installed and seemingly well configured, because by default I see "(gitblit)" links next to each patchset, which link a commit/ URL like https://git.wikimedia.org/commit/mediawiki%2Fcore/e425b429971a2a94a4a2fce3ca21eeeb41cf347c ; by commitdiff I meant an URL like https://git.wikimedia.org/commitdiff/mediawiki%2Fcore/e425b429971a2a94a4a2fce3ca21eeeb41cf347c which would also be a valid target.

I see the links to gitiles in your example and they're good; making each dir in "gerrit / Documentation/" a link is an improvement. However, no such links appear for us.

Do I need to report this to gitblit? If additional configuration is needed, can you give me pointers that I can pass to our sysadmins? Thank you again.
Apr 30, 2014
#4 dborowitz@google.com
Hm, if you're using 2.8.1 it might just be that those links hadn't been added yet. As a rule the version of the new change screen that made it into 2.8.1 wasn't fully baked. Waiting till 2.9 might be the best bet.
May 16, 2014
Project Member #5 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.9
Jul 18, 2014
Project Member #6 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting