| Issue 2517: | gerrit submodule references should be absolute | |
| 2 people starred this issue and may be notified of changes. | Back to list |
submodule reference in .gitmodules file is set to a relative path which means if you want to fork gerrit you must also fork the core plugins as well otherwise submodules will not work.
Affected Version: master
What steps will reproduce the problem?
1. fork gerrit
2. update submodules
git submodule init
git submodule sync
git submodule update --init
submodule in plugins folder doesn't get updated so you can't build the core plugins.
What is the expected output? What do you see instead?
I would expect to be able to do a release build after cloning gerrit. I don't think i should have to clone all of the plugins as well. I think if the relative paths were changed to point directly at the web URL then the submodule update will always work.
Mar 5, 2014
Project Member
#1
jrn@google.com
Mar 5, 2014
yes, I would agree. That's probably the best way to fix this problem however I think we should fix gerrit now so I would suggest setting the submodule to an absolute URL and also report this issue to upstream git.
Mar 5, 2014
I don't think Gerrit should set absolute URLs. This was done previously and it caused problems for users inside the corporate network that did not have external access to fetch from gerrit-review. Having the submodules with relative paths means we can mirror the plugin gits on our internal gerrit server.
Mar 5, 2014
(No comment was entered for this change.)
Status:
WontFix
|
|
| ► Sign in to add a comment |