My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2517: gerrit submodule references should be absolute
2 people starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  ----
Closed:  Mar 2014


Sign in to add a comment
 
Project Member Reported by zaro0508, Mar 5, 2014
submodule reference in .gitmodules file is set to a relative path which means if you want to fork gerrit you must also fork the core plugins as well otherwise submodules will not work.

Affected Version: master

What steps will reproduce the problem?
1. fork gerrit
2. update submodules 
      git submodule init
      git submodule sync
      git submodule update --init
      
submodule in plugins folder doesn't get updated so you can't build the core plugins.

What is the expected output? What do you see instead?
I would expect to be able to do a release build after cloning gerrit.  I don't think i should have to clone all of the plugins as well.    I think if the relative paths were changed to point directly at the web URL then the submodule update will always work.

Mar 5, 2014
Project Member #1 jrn@google.com
I think we should fix this in git. The idea would be:

 1. Make the base URL for submodules configurable separately from the 'origin' URL
 2. Use e.g. a special ref to tell git a good default for that setting

Then in your fork you would be able to push a setting to (say) refs/meta/git to tell people cloning from you to use your upstream as the base URL.

What do you think?
Mar 5, 2014
Project Member #2 zaro0508
yes, I would agree.  That's probably the best way to fix this problem however I think we should fix gerrit now so I would suggest setting the submodule to an absolute URL and also report this issue to upstream git. 

Mar 5, 2014
Project Member #3 david.pu...@sonymobile.com
I don't think Gerrit should set absolute URLs.

This was done previously and it caused problems for users inside the corporate network that did not have external access to fetch from gerrit-review.

Having the submodules with relative paths means we can mirror the plugin gits on our internal gerrit server.

Mar 5, 2014
Project Member #4 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: WontFix
Sign in to add a comment

Powered by Google Project Hosting