My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2513: "Cherry picked" message should contain the branch
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Mar 2014


Sign in to add a comment
 
Reported by org...@gmail.com, Mar 3, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: 2.8

What steps will reproduce the problem?
1. Cherry pick a change.

What is the expected output? What do you see instead?
The message reads: "This patchset was cherry picked to change: I2ca815af11513adcf71f0f72a7eeba1f3b0599ed"

This is not very informative, since the Change-Id is identical to the current change. A better message would be: "This patchset was cherry picked to branch otherbranch".
Mar 7, 2014
Project Member #2 david.pu...@sonymobile.com
Good idea.  I wasn't sure if this is needed on stable-2.8 but then when testing the current behaviour I found that the "cherry picked to" message currently isn't working at all.  See  issue #2520 .

Bruce is looking into it.  I guess since we have to fix this anyway, it's not too much effort to also fix the case described in this issue.
Mar 7, 2014
Project Member #3 david.pu...@sonymobile.com
Ignore my previous comment about the other bug.  Seems to have been a glitch in my environment.
Status: ChangeUnderReview
Mar 7, 2014
Project Member #4 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.8.2
Mar 8, 2014
#5 org...@gmail.com
How about adding a link to the new change?
Mar 9, 2014
Project Member #6 bruce.zu@sonymobile.com
I think you can config the system or project's 'commentlink'.
Mar 11, 2014
Project Member #7 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting