| Issue 250: | syntax highlighting fails when gerrit breaks long lines | |
| 1 person starred this issue and may be notified of changes. | Back to list |
Reported by Shawn Pearce <sop@google.com> on Mon Jul 20 15:00:15 PDT 2009 Source: JIRA GERRIT-251 Affected Version: 2.0.17 When Gerrit finds a source code line longer than 100 characters it automatically breaks the line to make it easier to read files in a side-by- side view on a laptop. However we break before the source code pretty formatter is applied, so the pretty formatter isn't able to render quoted strings correctly. For example: http://review.source.android.com/#patch,sidebyside,10721,1,src/main/java/com/google/gerrit/git/MergeOp.java Look at new version, line 780. The line should be styled as a quoted string, like line 769 is. The line break we insert causes the formatter to be unable to match the string literal here.
Sep 24, 2009
#1
code-rev...@gtempaccount.com
Sep 24, 2009
(No comment was entered for this change.)
Status:
Accepted
Owner: --- Blockedon: 251
Dec 18, 2009
(No comment was entered for this change.)
Blockedon:
363
Jan 30, 2010
Fixed by change I155bb7abc560f01a3597b3be678a76a5aa7f9e68
Status:
Fixed
Labels: FixedIn-2.1.2
Oct 21, 2012
(No comment was entered for this change.)
Status:
Released
Blockedon: -gerrit:251 -gerrit:363 gerrit:251 gerrit:363 Blocking: -gerrit:251 |
|
| ► Sign in to add a comment |