My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2493: Gerrit patchset-created event uploader field no more point to performer but to author
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Feb 2014


Sign in to add a comment
 
Reported by amu...@wikimedia.org, Feb 20, 2014
Affected Version: 2.8.1-1-g83098d0

What steps will reproduce the problem?
1. Create a change with Author: John Doe
2. Start gerrit stream-events to receive events as json
3. Log in Gerrit as user Jane Smith
4. Rebase the change by pressing the [rebase] button

What is the expected output? What do you see instead?

The rebase button creates a new patchset which cause Gerrit to emit a patchset-created event over stream-event channel.
The uploader field used to be the authenticated user doing the action (Jane Smith in my example above). Instead the uploader field points to the commit author.


A simplified structure of an event is:

 change:
  owner:
    name: JohnDoe
    project: team/software1
  patchset:
    author:
      name: JohnDoe
    uploader:
      name: JohnDoe
  type: patchset-created
  uploader:
    name: JohnDoe

The last field should be JaneSmith. It used to be the case in Gerrit 2.7.x

Our bug report is https://bugzilla.wikimedia.org/show_bug.cgi?id=60781
Feb 24, 2014
Project Member #2 David.Os...@gmail.com
(No comment was entered for this change.)
Status: ChangeUnderReview
Feb 24, 2014
Project Member #3 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.8.2
Mar 11, 2014
Project Member #4 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting