My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2492: commit-msg misses change id with leading whitespace
1 person starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  ----
Closed:  Feb 2014


Sign in to add a comment
 
Reported by ifanll...@live.com, Feb 20, 2014
It is helpful to be able to copy paste the Change-Id line from a git log output into a revision commit message.  Sadly, it is all too easy to copy the leading spaces of the git output line in the process.  The current script will then ignore the pasted Change-Id.

The simple fix for this is to modify line 40 to have:
	if grep -i '^[[:blank:]]{0,99}Change-Id:' "$MSG" >/dev/null

Feb 20, 2014
Project Member #1 bklarson@gmail.com
Will Gerrit recognize a change-id with leading whitespace?
Feb 20, 2014
Project Member #2 david.pu...@sonymobile.com
This is the expected behaviour.  Change-Id has to be at the start of the line, with no leading spaces.

Status: WontFix
Sign in to add a comment

Powered by Google Project Hosting