| Issue 249: | syntax coloring shouldn't interpret/color the text inside comments | |
| Back to list |
Reported by Andrew D. Stadler (Google) <stadler@android.com> on Sat Jul 18 22:48:52 PDT 2009 Source: JIRA GERRIT-250 The syntax coloring is triggering inside comments, which makes for some very odd (and sometimes questionable) coloring. For a quick example, just take a look at the standard android/apache header in almost any java file, which is displayed in multiple colors. This also comes out kind of weirdly: /* * Since this field is considered optional, we don't set this here. If * the user fills in a value we'll reset the current value, otherwise we * just leave the saved value alone. * * But let's set the hint, so that at least the user knows what's going to happen if * he doesn't fill anything in. */ Try that in some code - note: The first /* is red The first "Since" is red The various apostrophes trigger arbitrary green spans. Overall, it's doing reasonably well in real code, but it needs to recognize comments and color them all uniformly.
Sep 24, 2009
#1
code-rev...@gtempaccount.com
Sep 24, 2009
Comment by Shawn Pearce <sop@google.com> on Mon Jul 20 15:52:18 PDT 2009 Fixed by https://review.source.android.com/10732
Sep 24, 2009
Update by Shawn Pearce <sop@google.com> on Mon Jul 20 15:52:18 PDT 2009 Fixed in version 2.0.17.
Status:
Fixed
Sep 25, 2009
(No comment was entered for this change.)
Labels:
FixedIn-2.0.17
Oct 21, 2012
(No comment was entered for this change.)
Status:
Released
|
|
| ► Sign in to add a comment |