My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2481: Once Diff view is getting unified view for binary files, prev/next is keep displaying unified view only
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  May 2014


Sign in to add a comment
 
Reported by kwanhong...@gmail.com, Feb 16, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: master branch (tested on e1a1220db9cd8d119678493d308ee9d05511c48c)

What steps will reproduce the problem?
1. Set preferred Change View to New Screen.
2. In Change screen, click normal file(i.e. xml file) right next of binary file(i.e. png file) to enter diff view.
3. Once diff view for xml file is displayed, click previous button to go to png file.
4. Once diff view for png file is displayed, click next button to go back to diff view for xml file.

What is the expected output? What do you see instead?
By #2, Side by Side diff view is displayed. This is ok.
By #3, Unified diff view is displayed. This is ok.
By #4, Unified diff view is displayed. This is not ok. This should be Side By Side diff view again because it is by step #2.

Please provide any additional information below.
I tested this with https://android-review.googlesource.com/47211
I don't know what the change is, but it's good to test because it has png and xml file changes
May 16, 2014
Project Member #1 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.9
Jul 18, 2014
Project Member #2 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting