My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2480: Documentation: code snippets have a double border
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  fishyw...@google.com
Closed:  Feb 2014
Cc:  fishyw...@google.com


Sign in to add a comment
 
Project Member Reported by david.pu...@sonymobile.com, Feb 16, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: master

What steps will reproduce the problem?
1. View the rendered HTML for a file that uses the `[source, xyz]` classifiers above code snippets, for example dev-plugins.txt
2.
3.

What is the expected output? What do you see instead?

The code snippets have a double border around them.  The outer border and grey fill is done by the .content and .listingblock styles, and the inner one comes from the .pre.prettyprint style.

After removing the latter via Chrome's element inspection tool, it looks better.

Please provide any additional information below.

See attachment for example of double borders.

.pre.prettyprint is defined in the gerrit-prettify module but that does not seem to be used in the documentation.  Instead it is using the CSS file from [1]

[1] http://cdnjs.cloudflare.com/ajax/libs/prettify/r298/prettify.min.css

Screenshot from 2014-02-17 14:08:07.png
31.2 KB   View   Download
Feb 18, 2014
Project Member #1 fishyw...@google.com
Yes this is CSS issue. https://gerrit-review.googlesource.com/54721 should fix it.
Status: Accepted
Owner: fishyw...@google.com
Feb 18, 2014
Project Member #2 david.pu...@sonymobile.com
https://gerrit-review.googlesource.com/#/c/54705/
Status: Submitted
Labels: FixedIn-2.8.2
Mar 11, 2014
Project Member #3 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting